Bug 1404186
| Summary: | attaching a new multi-queue vhost-user interface to a running VM fails | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Marcel Kolaja <mkolaja> |
| Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> |
| Status: | CLOSED ERRATA | QA Contact: | yalzhang <yalzhang> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.0 | CC: | dyuan, jdenemar, juzhang, knoel, mprivozn, pezhang, rbalakri, rhosp-bugs-internal, srevivo, xuzhang, yalzhang |
| Target Milestone: | rc | Keywords: | ZStream |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-2.0.0-10.el7_3.4 | Doc Type: | Bug Fix |
| Doc Text: |
Prior to this update, the libvirt service was not able to attach vhost-user type interface to running QEMU machine. To fix the bug, an implementation has been introduced to libvirt that enables it to attach and detach vhost-user type interfaces.
|
Story Points: | --- |
| Clone Of: | 1386976 | Environment: | |
| Last Closed: | 2017-01-17 18:27:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1386976 | ||
| Bug Blocks: | |||
|
Description
Marcel Kolaja
2016-12-13 09:36:12 UTC
The following commit causes a memory leak:
libvirt-2.0.0/src/qemu/qemu_hotplug.c:1278: var_assign: Assigning: "originalError" = storage returned from "virSaveLastError()".
libvirt-2.0.0/src/qemu/qemu_hotplug.c:1272: leaked_storage: Variable "originalError" going out of scope leaks the storage it points to.
commit 0e82fa4c345acb7ad52e0da0e54f7375eda57657
Refs: v2.4.0-50-g0e82fa4c3
Author: Michal Privoznik <mprivozn>
AuthorDate: Tue Oct 25 12:16:36 2016 +0200
Commit: Michal Privoznik <mprivozn>
CommitDate: Thu Nov 10 16:47:32 2016 +0100
qemuDomainAttachNetDevice: Don't overwrite error on rollback
If there is an error hotpluging a net device (for whatever
reason) a rollback operation is performed. However, whilst doing
so various helper functions that are called report errors on
their own. This results in the original error to be overwritten
and thus misleading the user.
Signed-off-by: Michal Privoznik <mprivozn>
Moving to POST: http://post-office.corp.redhat.com/archives/rhvirt-patches/2016-December/msg00236.html Test with below packages, the result is expected.
libvirt-2.0.0-10.el7.3.x86_64 (build from libvirt-2.0.0-10.el7_3.3 with the patch in #c7)
qemu-kvm-rhev-2.6.0-28.el7_3.3.x86_64
1. # cat vhostuser2.xml
<interface type='vhostuser'>
<source type='unix' path='/var/run/openvswitch/vhost-user2' mode='client'/>
<model type='virtio'/>
<driver name='vhost' queues='4'/>
</interface>
2. # virsh attach-device r7 vhostuser2.xml
Device attached successfully
3. # virsh dumpxml r7 | grep /interface -B7
<interface type='vhostuser'>
<mac address='52:54:00:b5:1d:c0'/>
<source type='unix' path='/var/run/openvswitch/vhost-user2' mode='client'/>
<model type='virtio'/>
<driver name='vhost' queues='4'/>
<alias name='net1'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
</interface>
check on the guest, the new attached interface is existed.
4. # virsh detach-interface r7 vhostuser 52:54:00:b5:1d:c0
Interface detached successfully
check the xml and on the guest, the interface is gone.
Test on below packages, the result is expected, set the bug to verified.
libvirt-2.0.0-10.el7_3.4.x86_64
qemu-kvm-rhev-2.6.0-28.el7_3.3.x86_64
1. # virsh start r7
Domain r7 started
# cat vhostuser1.xml
<interface type='vhostuser'>
<source type='unix' path='/var/run/openvswitch/vhost-user1' mode='client'/>
<model type='virtio'/>
<driver name='vhost' queues='4'/>
</interface>
2. # virsh attach-device r7 vhostuser1.xml
Device attached successfully
# virsh dumpxml r7 | grep /interface -B7
<interface type='vhostuser'>
<mac address='52:54:00:dd:7c:6e'/>
<source type='unix' path='/var/run/openvswitch/vhost-user1' mode='client'/>
<model type='virtio'/>
<driver name='vhost' queues='4'/>
<alias name='net0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>
3. on the guest
# ethtool -l eth0
Channel parameters for eth0:
Pre-set maximums:
RX: 0
TX: 0
Other: 0
Combined: 4
Current hardware settings:
RX: 0
TX: 0
Other: 0
Combined: 1
# ethtool -L eth0 combined 4
# ethtool -l eth0
Channel parameters for eth0:
Pre-set maximums:
RX: 0
TX: 0
Other: 0
Combined: 4
Current hardware settings:
RX: 0
TX: 0
Other: 0
Combined: 4
4. detach
# virsh detach-interface r7 vhostuser 52:54:00:dd:7c:6e
Interface detached successfully
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2017-0098.html Dear bigswitch, in bug 1386976#c10 you say that the attach fails for you. I'm moving the discussion here because this bug is for the version you have. Can you please get full libvirt debug logs and attach them here? http://wiki.libvirt.org/page/DebugLogs Thanks, Michal The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |