Bug 1404265

Summary: device name "ovs" causes "Invalid OVS interface type Bridge"
Product: Red Hat Enterprise Linux 7 Reporter: Petr Horáček <phoracek>
Component: initscriptsAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED WONTFIX QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.2CC: danken, initscripts-maint-list, mburman
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1762717 (view as bug list) Environment:
Last Closed: 2021-01-15 07:29:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1402267, 1762717    

Description Petr Horáček 2016-12-13 13:52:02 UTC 
Description of problem:
When we use "ovs" as a device name while creating a linux bridge via ifcfg (with NetworkManager disabled) initscripts thinks we want to create an Open vSwitch device.

Version-Release number of selected component (if applicable):
both initscripts-9.49.30 and initscripts-9.65

How reproducible:
Always

Steps to Reproduce:
$ echo '\
DEVICE=ovs
TYPE=Bridge
ONBOOT=no
NM_CONTROLLED=no' > /etc/sysconfig/network-scripts/ifcfg-ovs
$ ifup ovs

Actual results:
Fails with "Invalid OVS interface type Bridge".

Expected results:
Create a linux bridge with name 'ovs'.
Comment 1 Lukáš Nykrýn 2016-12-13 15:51:57 UTC 
The problem is here:
https://github.com/fedora-sysv/initscripts/blob/master/sysconfig/network-scripts/network-functions#L117

There is no case for TYPE = Bridge
Since the bridge stuff is handled by the ifup-eth we could probably add case that  would assign it to "eth"

Problem is that bridging is not strictly limited to ethernet (see https://wiki.linuxfoundation.org/networking/bridge "What can be bridged?" ).
And in theory user could have its own special ifup-whatever for network that is not ethernet-based but also do bridging and have DEVICE=whatever1 Type=Bridge.

But this case is pretty unlikely.
Comment 3 Dan Kenigsberg 2017-01-08 14:54:28 UTC 
*** Bug 1402267 has been marked as a duplicate of this bug. ***
Comment 4 Lukáš Nykrýn 2017-02-28 15:38:40 UTC 
Possible fix:

https://github.com/fedora-sysv/initscripts/pull/62
Comment 9 RHEL Program Management 2021-01-15 07:29:12 UTC 
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.