Bug 1404290

Summary: socat build failure on rawhide (fc26)
Product: [Fedora] Fedora Reporter: Michel Normand <normand>
Component: socatAssignee: Paul Wouters <pwouters>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: pwouters
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: socat-1.7.3.2-1.fc24 socat-1.7.3.2-1.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-12 14:46:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Michel Normand 2016-12-13 14:47:42 UTC 
socat 1.7.3.1 build failure with openssl-devel-1:1.1.0c-3 as tried by scratchbuild (1)

The RAND_F_SSLEAY_RAND_BYTES error may be solved by a patch like (2)
But I do not identified a solution for incomplete type 'DH' error.


(1) https://kojipkgs.fedoraproject.org//work/tasks/4505/16864505/build.log
=== extract
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m32 -march=i686 -fasynchronous-unwind-tables -D_GNU_SOURCE -Wall -Wno-parentheses  -DHAVE_CONFIG_H -I.  -I.   -c -o xio-tun.o xio-tun.c
xio-openssl.c: In function '_xioopen_openssl_prepare':
xio-openssl.c:948:5: error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
   dh->p = BN_bin2bn(dh2048_p, sizeof(dh2048_p), NULL);
     ^~
xio-openssl.c: In function 'openssl_SSL_ERROR_SSL':
xio-openssl.c:1106:4: error: 'RAND_F_SSLEAY_RAND_BYTES' undeclared (first use in this function)
   (RAND_F_SSLEAY_RAND_BYTES<<12)|
    ^~~~~~~~~~~~~~~~~~~~~~~~
===

(2)
===
Index: socat-1.7.3.1/xio-openssl.c
===================================================================
--- socat-1.7.3.1.orig/xio-openssl.c
+++ socat-1.7.3.1/xio-openssl.c
@@ -16,6 +16,9 @@
 #include "xio-listen.h"
 #include "xio-ipapp.h"
 #include "xio-openssl.h"
+#ifndef RAND_F_SSLEAY_RAND_BYTES
+#define RAND_F_SSLEAY_RAND_BYTES RAND_F_RAND_BYTES
+#endif
===
Comment 1 Fedora Update System 2017-02-03 00:54:41 UTC 
socat-1.7.3.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-de7e691b8b
Comment 2 Fedora Update System 2017-02-03 00:55:15 UTC 
socat-1.7.3.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-391e24bbc9
Comment 3 Fedora Update System 2017-02-03 22:54:54 UTC 
socat-1.7.3.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-de7e691b8b
Comment 4 Fedora Update System 2017-02-03 23:50:17 UTC 
socat-1.7.3.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-391e24bbc9
Comment 5 Fedora Update System 2017-02-12 14:46:55 UTC 
socat-1.7.3.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 6 Fedora Update System 2017-02-12 19:51:20 UTC 
socat-1.7.3.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.