Bug 1404361

Summary: segfault in bs_size_add during F25 install
Product: [Fedora] Fedora Reporter: David Shea <dshea>
Component: libbytesizeAssignee: Vratislav Podzimek <vpodzime>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: vpodzime
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libbytesize-0.7-5.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-19 23:23:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
backtrace
none
anaconda.log
none
storage.log
none
program.log
none
packaging.log
none
syslog none

Description David Shea 2016-12-13 16:30:58 UTC
Created attachment 1231274 [details]
backtrace

Description of problem:
Segfault during custom partition

Version-Release number of selected component (if applicable):
Fedora-Server-netinst-x86_64-25-1.3.iso

How reproducible:
always

Steps to Reproduce:
- Booted up from a USB stick, UEFI. sda is a fresh 1TB hard drive, sdb is a drive I'm ignoring, sdc is the boot media
- Select sda in disk selection, custom partition
- Hit the autopart button
- Shrink /home to 800 GiB, increase swap to an admittedly ludicrous 48GiB in case I ever try to hibernate, clear the size on /home and update again to grow to fit
- Go to the modify window for the volume group
- change the name, check the encrypt checkbox
- Crash happens upon hitting save

I've got a core dump if anyone really wants it, but since I don't feel like hosting it anywhere I'm going to attach the backtrace from gdb (also, I'm only doing the thread that crashed). The highlight of that is that bs_size_add is being called with size2=NULL, and if you go up a few frames that's because blivet's Size.__add__ is called with other=None. So maybe it's actually blivet's fault, or something higher up. I dunno.

Logs to follow.

Comment 1 David Shea 2016-12-13 16:31:31 UTC
Created attachment 1231275 [details]
anaconda.log

Comment 2 David Shea 2016-12-13 16:31:54 UTC
Created attachment 1231276 [details]
storage.log

Comment 3 David Shea 2016-12-13 16:32:22 UTC
Created attachment 1231277 [details]
program.log

Comment 4 David Shea 2016-12-13 16:32:50 UTC
Created attachment 1231278 [details]
packaging.log

Comment 5 David Shea 2016-12-13 16:34:15 UTC
Created attachment 1231279 [details]
syslog

Comment 6 Vratislav Podzimek 2016-12-13 20:32:31 UTC
I accidentally hit the same issue as well today. Almost looks like it only started happening today. :)

Comment 7 Vratislav Podzimek 2016-12-14 09:01:24 UTC
https://github.com/rhinstaller/libbytesize/pull/23

Comment 8 Vratislav Podzimek 2016-12-15 10:30:16 UTC
(In reply to Vratislav Podzimek from comment #7)
> https://github.com/rhinstaller/libbytesize/pull/23

Merged.

Comment 9 Fedora Update System 2016-12-16 19:20:44 UTC
libbytesize-0.7-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c84dbd4b46

Comment 10 Fedora Update System 2016-12-19 02:30:01 UTC
libbytesize-0.7-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c84dbd4b46

Comment 11 Fedora Update System 2016-12-19 23:23:30 UTC
libbytesize-0.7-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.