Bug 1404393

Summary:	pulp-puppet-module-builder will no longer build modules with Modulefile on Puppet 4 systems
Product:	Red Hat Satellite	Reporter:	David Davis <daviddavis>
Component:	Docs Puppet Guide	Assignee:	Stephen Wadeley <swadeley>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Charles Wood <chwood>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.3.0	CC:	adahms, sbream
Target Milestone:	Unspecified
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1431661 (view as bug list)		Environment:
Last Closed:	2017-03-13 15:12:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1431661

Description David Davis 2016-12-13 18:08:39 UTC

Puppet 4 is dropping support for Modulefile [0]. Because the pulp-puppet-module-builder script relies on puppet to build puppet modules, it will no longer build puppet modules with Modulefile (and no metadata.json) if the system it's running on has Puppet 4 installed. Modulefile has been deprecated for a while now so I'd recommend users update their puppet modules to store metadata in metadata.json instead of Modulefile. 

Wondering if we need a note in the documentation about this.

[0] From the puppet 4 documentation (https://docs.puppet.com/puppet/latest/modules_publishing.html):

"Throughout the Puppet 3.x series, deprecation warnings were issued for Modulefile. If you still have a Modulefile, it will be treated like any other text file in the root directory of the module. You will need to move any metadata contained in it to the metadata.json."

Comment 1 Andrew Dahms 2017-02-03 04:25:38 UTC

Assigning to Stephen for review.

Comment 4 Stephen Wadeley 2017-02-03 13:54:34 UTC

Hello

pulp-puppet-module-builder is mentioned on this page [1]

That seems a good place to mention this issue.


[1] Adding Puppet Modules from a Git Repository — https://access.redhat.com/documentation/en/red-hat-satellite/6.2/paged/puppet-guide/35-adding-puppet-modules-from-a-git-repository

Comment 5 Stephen Wadeley 2017-03-06 21:19:17 UTC

(In reply to Stephen Wadeley from comment #4)
> Hello
> 
> pulp-puppet-module-builder is mentioned on this page [1]
> 
> That seems a good place to mention this issue.
> 
> 
Link changed:

> [1] Adding Puppet Modules from a Git Repository —

https://access.redhat.com/documentation/en-us/red_hat_satellite/6.2/html/puppet_guide/chap-red_hat_satellite-puppet_guide-adding_puppet_modules_to_red_hat_satellite_6#sect-Red_Hat_Satellite-Puppet_Guide-Adding_Puppet_Modules_to_Red_Hat_Satellite_6-Adding_Puppet_Modules_from_a_Git_Repository

Comment 8 Steve Bream 2017-03-13 13:55:02 UTC

Hi Stephen,

Yes, let's change the para in question to read: 

Puppet
    Red Hat Satellite 6 includes supported Puppet packages. The installation program allows users to install and configure Puppet Masters as a part of Red Hat Satellite Capsule Servers. A Puppet module, running on a Puppet Master on the Red Hat Satellite Server or Satellite Capsule Server is supported by Red Hat.

And add: 

For information on what versions of Puppet are supported, see https://access.redhat.com/articles/1343683.

Thanks,
Steve

Comment 9 Stephen Wadeley 2017-03-13 14:30:54 UTC

Thank you Steve for comment 8, cloning for Arch Guide

Comment 12 Stephen Wadeley 2017-03-13 15:12:43 UTC

Hello

These updates are now live on the customer portal.

Adding Puppet Modules from a Git Repository


https://access.redhat.com/documentation/en-us/red_hat_satellite/6.2/html/puppet_guide/chap-red_hat_satellite-puppet_guide-adding_puppet_modules_to_red_hat_satellite_6#sect-Red_Hat_Satellite-Puppet_Guide-Adding_Puppet_Modules_to_Red_Hat_Satellite_6-Adding_Puppet_Modules_from_a_Git_Repository


Thank you