Bug 1404417

Summary: Build status will report "running for -1h"
Product: OpenShift Container Platform Reporter: Will Gordon <wgordon>
Component: Management ConsoleAssignee: Jessica Forrester <jforrest>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.3.1CC: aos-bugs, dmcphers, jokerman, mmccomas, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Relative time and duration calculations were not preventing negative numbers from showing. Consequence: Under normal client and server clock situations negative numbers would not happen. However when there was clock skew between the browser client and the server then negative times could appear on objects like builds in the console. Fix: Prevent relative times and durations from returning negative values by forcing them to zero. Result: Negative relative times and durations will not appear in the console.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-12 19:18:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Image of problem in action none

Description Will Gordon 2016-12-13 19:31:13 UTC 
Description of problem:
When running `oc start-build <name> --from-repo=../<name>" the web console updates with "waiting for -1h" or "running for -1h".


Version-Release number of selected component (if applicable):
v3.3.1.3

How reproducible:
Every time, however, it's only brief until it starts to count up normally in seconds

Steps to Reproduce:
1. oc start-build <name> --from-repo=../<name>
2.
3.

Actual results:
Running for -1h

Expected results:
Running for 1s

Additional info:
Comment 1 Will Gordon 2016-12-13 19:32:08 UTC 
Created attachment 1231317 [details]
Image of problem in action
Comment 2 Jessica Forrester 2016-12-13 20:01:04 UTC 
Negative durations should no longer appear, this has already been fixed for origin 1.5
Comment 3 Jessica Forrester 2016-12-13 20:03:52 UTC 
actually we fixed one of the duration filters but not the other. will fix the other one
Comment 4 openshift-github-bot 2016-12-13 21:02:35 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/9b35ca7feb2804913f006b79098d43cd050302bc
Bug 1404417 - Don't show negative durations, they are always due to client clock skew
Comment 5 Troy Dawson 2017-01-20 22:57:39 UTC 
This has been merged into ocp and is in OCP v3.5.0.7 or newer.
Comment 6 Yadan Pei 2017-01-24 03:11:14 UTC 
Checked against v3.5.0.7+390ef18

When Build is in New & Pending status, Duration will not be calculated, neither will be shown in table(See attachment NewPending)

Duration will be calculated from 0 seconds when builds changes to Running(See attachment PendingtoRunning)


Move to VERIFIED
Comment 9 Jessica Forrester 2017-03-14 17:36:32 UTC 
*** Bug 1432158 has been marked as a duplicate of this bug. ***
Comment 11 errata-xmlrpc 2017-04-12 19:18:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0884