Bug 1404442

Summary:	The root inode is not cached by md-cache
Product:	[Community] GlusterFS	Reporter:	Shreyas Siravara <sshreyas>
Component:	md-cache	Assignee:	Shreyas Siravara <sshreyas>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, pgurusid, rgowdapp, vbellur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.1.3 (or later)	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1404766 (view as bug list)		Environment:
Last Closed:	2018-08-29 03:37:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shreyas Siravara 2016-12-13 21:19:42 UTC

Description of problem:
- `is_mdc_key_satisfied()` is returning 0 when it has not checked any of the keys
- This causes the cache'd value for the root inode to always be invalid (`mdc_xattr_satisfied()` returns 0, which causes us to jump to `uncached').
- In this diff we add a new option called "strict-xattrs", when enabled winds getxattr calls for those keys not present in our cache.
- This allows "special" getxattr commands (quota cli commands for example) to work when md-cache is enabled.


Version-Release number of selected component (if applicable): Found in FB development branaches


How reproducible: Always reproducible


Committed in release-3.8-fb @ http://review.gluster.org/#/c/16060/

Comment 1 Worker Ant 2016-12-13 21:22:26 UTC

REVIEW: http://review.gluster.org/16125 (performance/md-cache: Fix caching for root inode) posted (#1) for review on master by Shreyas Siravara (sshreyas)

Comment 2 Worker Ant 2016-12-14 03:44:13 UTC

REVIEW: http://review.gluster.org/16125 (performance/md-cache: Fix caching for root inode) posted (#2) for review on master by Shreyas Siravara (sshreyas)

Comment 3 Worker Ant 2016-12-14 03:46:11 UTC

REVIEW: http://review.gluster.org/16125 (performance/md-cache: Fix caching for root inode) posted (#3) for review on master by Shreyas Siravara (sshreyas)

Comment 4 Worker Ant 2016-12-14 04:09:23 UTC

REVIEW: http://review.gluster.org/16126 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#1) for review on release-3.8-fb by Shreyas Siravara (sshreyas)

Comment 5 Worker Ant 2016-12-14 04:10:47 UTC

REVIEW: http://review.gluster.org/16126 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#2) for review on release-3.8-fb by Shreyas Siravara (sshreyas)

Comment 6 Worker Ant 2016-12-14 04:23:28 UTC

REVIEW: http://review.gluster.org/16126 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#3) for review on release-3.8-fb by Shreyas Siravara (sshreyas)

Comment 7 Worker Ant 2016-12-15 00:15:52 UTC

REVIEW: http://review.gluster.org/16134 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#1) for review on master by Shreyas Siravara (sshreyas)

Comment 8 Worker Ant 2016-12-15 01:40:58 UTC

REVIEW: http://review.gluster.org/16134 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#2) for review on master by Shreyas Siravara (sshreyas)

Comment 9 Worker Ant 2016-12-15 15:41:41 UTC

REVIEW: http://review.gluster.org/16134 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#3) for review on master by Shreyas Siravara (sshreyas)

Comment 10 Worker Ant 2017-02-17 23:00:04 UTC

REVIEW: https://review.gluster.org/16134 (performance/md-cache: Add an option to cache all xattrs for an inode) posted (#4) for review on master by Jeff Darcy (jdarcy)

Comment 11 Vijay Bellur 2017-04-18 20:09:59 UTC

*** Bug 1428050 has been marked as a duplicate of this bug. ***

Comment 12 Amar Tumballi 2018-08-29 03:37:44 UTC

This update is done in bulk based on the state of the patch and the time since last activity. If the issue is still seen, please reopen the bug.