Bug 1404725

Summary:	SSSD does not skip GPO if no gpcFunctionalityVersion present
Product:	Red Hat Enterprise Linux 7	Reporter:	Jakub Hrozek <jhrozek>
Component:	sssd	Assignee:	SSSD Maintainers <sssd-maint>
Status:	CLOSED ERRATA	QA Contact:	Dan Lavu <dlavu>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.4	CC:	abondare, ealcaniz, grajaiya, jhrozek, lslebodn, mkosek, mzidek, pbrezina, sgoveas
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	sssd-1.15.0-2.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1404697	Environment:
Last Closed:	2017-08-01 09:02:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1404697
Bug Blocks:

Description Jakub Hrozek 2016-12-14 13:49:15 UTC

+++ This bug was initially created as a clone of Bug #1404697 +++

Description of problem:

If the  groupPolicyContainer created by some tool (for example the https://www.quest.com/products/password-manager/) does not conatin gpcFunctionalityVersion attribute and sssd stumbles upon such container, it stops the processing and just quit with the default decision (wich is usually deny).

To avoid this problem, the SSSD should skip any GPO that does not contain the gpcFunctionalityVersion because this is the behavior specified by the MS-GPOL, see 3.2.5.1.6:

-----
3.2.5.1.6 GPO Filter Evaluation
In this step, the client MUST process the GPO as follows:
 1. Check for the functionality version of the GPO. If the gPCFunctionalityVersion
    field of the Group Policy Object Search message (as defined in [MS-ADA1]
    section 2.278) is not set to 2, the GPO MUST NOT be included in the rest
    of the protocol sequence. The GPO MUST be considered denied.
-----

given that the GPO itself does not have access control rules, you filter
it out. 


Version-Release number of selected component (if applicable):

sssd-1.14.0-43.el7.x86_64                


Steps to Reproduce:
1. create GPO with https://www.quest.com/products/password-manager/
2. try to log in with such user 

Actual results:

login fails

Expected results:


should log in

--- Additional comment from Andrey Bondarenko on 2016-12-14 08:48:48 EST ---

Correct versions for the 6.8 related bug:

sssd-1.13.3-22.el6_8.4.x86_64                               Sun Oct 30 11:19:34 2016
sssd-ad-1.13.3-22.el6_8.4.x86_64                            Sun Oct 30 11:19:32 2016
sssd-client-1.13.3-22.el6_8.4.x86_64                        Sun Oct 30 11:19:30 2016
sssd-common-1.13.3-22.el6_8.4.x86_64                        Sun Oct 30 11:19:31 2016

Comment 2 Jakub Hrozek 2016-12-15 15:27:07 UTC

Upstream ticket:
https://fedorahosted.org/sssd/ticket/3269

Comment 6 Lukas Slebodnik 2017-01-26 13:44:11 UTC

master:
* 47680083e7e4bf5c433657171bf84cceacc83339
* 6a490b312075d2588ad87bbb8a63466f1ac6a106

sssd-1-14:
* 9bf6c4b5afb5054282f7b8c4c5f7bed26a259f5a
* 94903da8a3723094948b4b99b30f6449fed809da

sssd-1-13:
* 627edf70ab2571d504bc23fdf3b15ce7983d4388
* 0ee20e9ece0d24c335f604b20e1ba7c8ea1d669d

Comment 8 Dan Lavu 2017-05-17 20:39:57 UTC

Verified against sssd-1.15.2-24.el7.x86_64, the user is able to login and the policy with the deleted attribute is ignored. 

--- 

[root@dell-per905-01 /]# ssh test_sssd@localhost
test_sssd@localhost's password: 

Last login: Wed May 17 16:38:03 2017 from ::1

--- 

(Wed May 17 16:31:51 2017) [sssd[be[sssdad2012r2.com]]] [ad_gpo_sd_process_attrs] (0x4000): smb_path: /sssdad2012r2.com/Policies/{0A72F5AD-88B2-48C8-B220-8779592E03F9}
(Wed May 17 16:31:51 2017) [sssd[be[sssdad2012r2.com]]] [ad_gpo_sd_process_attrs] (0x4000): GPO with GUID {0A72F5AD-88B2-48C8-B220-8779592E03F9} is missing attribute gPCFunctionalityVersion and will be skipped.
00C04FB984F9}

Comment 9 errata-xmlrpc 2017-08-01 09:02:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:2294