Bug 1405067

Summary: Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang
Product: [Fedora] Fedora Reporter: Jan Chaloupka <jchaloup>
Component: Package ReviewAssignee: Frantisek Kluknavsky <fkluknav>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fkluknav, package-review
Target Milestone: ---Flags: fkluknav: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-08 13:26:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1405072    

Description Jan Chaloupka 2016-12-15 14:06:43 UTC
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-xeipuuv-gojsonpointer/golang-github-xeipuuv-gojsonpointer.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-xeipuuv-gojsonpointer/golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc24.src.rpm

Description: JSON Pointer implementation in Golang

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16901269

$ rpmlint golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc24.src.rpm golang-github-xeipuuv-gojsonpointer-devel-0-0.1.gite0fe6f6.fc24.noarch.rpm golang-github-xeipuuv-gojsonpointer-unit-test-devel-0-0.1.gite0fe6f6.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Frantisek Kluknavsky 2017-01-16 15:53:52 UTC
MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)

%if 0%{?with_devel}
%files devel -f devel.file-list
%license LICENSE-APACHE-2.0.txt
%doc README.md
%dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}
%endif

%if 0%{?with_unit_test} && 0%{?with_devel}
%files unit-test-devel -f unit-test-devel.file-list
%license LICENSE-APACHE-2.0.txt
%doc README.md
%endif


README.md in both subpackages is correct?

Comment 2 Jan Chaloupka 2017-01-16 16:02:50 UTC
Thanks for pointing that out. I will fix that in the spec file once built. Any other issues with the spec file?

Comment 3 Frantisek Kluknavsky 2017-01-16 16:54:54 UTC
No. It seems OK.

Comment 4 Gwyn Ciesla 2017-01-23 15:56:29 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-xeipuuv-gojsonpointer

Comment 5 Fedora Update System 2017-02-01 12:17:06 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8eeb53ead

Comment 6 Fedora Update System 2017-02-01 12:17:27 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e5e71cb8be

Comment 7 Fedora Update System 2017-02-01 12:17:46 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0ee0430361

Comment 8 Fedora Update System 2017-02-01 12:18:09 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e84ba0b097

Comment 9 Fedora Update System 2017-02-01 22:18:55 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e5e71cb8be

Comment 10 Fedora Update System 2017-02-01 22:48:15 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e84ba0b097

Comment 11 Fedora Update System 2017-02-01 23:51:47 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0ee0430361

Comment 12 Fedora Update System 2017-02-02 03:48:42 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8eeb53ead

Comment 13 Fedora Update System 2017-03-08 13:26:34 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-03-08 13:54:39 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-03-08 15:52:06 UTC
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.