Bug 1405439
| Summary: | systemd-system-upgrade-generator should warn if runlevel is specified on the kernel commandline | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Kratochvil <jan.kratochvil> | ||||
| Component: | systemd | Assignee: | systemd-maint | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 26 | CC: | jan.kratochvil, johannbg, lnykryn, msekleta, muadda, ssahani, s, systemd-maint, wwoods, zbyszek | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | systemd-233-2.fc26 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-03-02 20:12:06 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Jan Kratochvil
2016-12-16 14:06:33 UTC
> # systemctl enable dnf-system-upgrade.service > Created symlink from /etc/systemd/system/system-update.target.wants/dnf-system-upgrade.service to /usr/lib/systemd/system/dnf-system-upgrade.service. That's actually a noop, dnf-plugin-system-upgrade already contains /usr/lib/systemd/system/system-update.target.wants/dnf-system-upgrade.service. > Actual results: > 5.1G /system-update/ > But the system boots as F-24 with no trace of an upgrade attempt. That's strange. Can you attach logs from the boot that should have cause the upgrade but didn't (journalctl -b X) where X is -1 or -2 or less. Created attachment 1232560 [details]
boot log.xz
I don't see anything interesting in the logs.
If you still have the symlink, does this work:
mkdir /tmp/x && SYSTEMD_LOG_LEVEL=debug /usr/lib/systemd/system-generators/systemd-system-update-generator /tmp/{x,x,x} && ls -l /tmp/x
? (It should say "... default.target -> /usr/lib/systemd/system/system-update.target")
total 0 lrwxrwxrwx 1 root root 44 Dec 16 16:32 default.target -> /usr/lib/systemd/system/system-update.target OK, it is because I always boot the system with parameter "3", otherwise it locks up trying to repeatedly unsuccessfully run X: # cat /proc/cmdline BOOT_IMAGE=/vmlinuz-4.8.13-200.fc24.x86_64 root=LABEL=host2root ro rd.luks.options=discard rd.luks.uuid=luks-5b30fc63-6b52-4746-b883-394fbe23c3dd LANG=en_US.UTF-8 3 I think 'dnf system-upgrade reboot' should check /proc/cmdline and warn if there has been changed the default target to run. I'm not even sure if this behaviour is a bug. The general rule is that the commandline has higher priority than /etc, which has higher priority than /usr/lib. But in this case this means that paradoxically, the override is overridden. This might be unexpected, but it seems to be right thing. So you're right, basically we should add a warning message. system-update-generator should do that. BTW, thanks for debugging this. I didn't think about this case at all. This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. |