Bug 1405537
Summary: | fix non-active block commit with automatic disk locking (virtlockd) | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | Peter Krempa <pkrempa> |
Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
Status: | CLOSED ERRATA | QA Contact: | Han Han <hhan> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 8.0 | CC: | hhan, jdenemar, xuzhang, yalzhang |
Target Milestone: | rc | ||
Target Release: | 8.1 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | libvirt-5.10.0-1.el8 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-05-05 09:43:16 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peter Krempa
2016-12-16 16:19:54 UTC
Other similar bzs: https://bugzilla.redhat.com/show_bug.cgi?id=1191901 https://bugzilla.redhat.com/show_bug.cgi?id=1302168 This bug is going to be addressed in next major release. As of the following commit commit 3f93884a4d047a012b968c62b94ea07dadd1759b Author: Peter Krempa <pkrempa> Date: Mon Jul 22 13:39:24 2019 +0200 qemu: Add -blockdev support for block commit job Introduce the handler for finalizing a block commit and active bloc commit job which will allow to use it with blockdev. if -blockdev is enabled we can properly remove locks from the backing chain members thus no locks should be leaked when virtlockd is used. The blockdev feature was enabled since: commit c6a9e54ce3252196f1fc6aa9e57537a659646d18 Author: Peter Krempa <pkrempa> Date: Mon Jan 7 11:45:19 2019 +0100 qemu: enable blockdev support Now that all pieces are in place (hopefully) let's enable -blockdev. We base the capability on presence of the fix for 'auto-read-only' on files so that blockdev works properly, mandate that qemu supports explicit SCSI id strings to avoid ABI regression and that the fix for 'savevm' is present so that internal snapshots work. v5.9.0-390-gc6a9e54ce3 and requires upstream qemu-4.2 or appropriate downstream. Verified on libvirt-6.0.0-1.module+el8.2.0+5453+31b2b136.x86_64 qemu-kvm-4.2.0-6.module+el8.2.0+5453+31b2b136.x86_64 selinux-policy-3.14.3-30.el8.noarch Prepare: Set selinux to permissive to bypass BZ1792713 1. Set qemu.conf: lock_manager = "lockd" 2. Restart libvirtd and virtlockd # systemctl restart libvirtd.socket virtlockd.socket libvirtd virtlockd 3. Start an VM the do external snapshot and blockcommit: ➜ ~ virsh snapshot-create-as pc s1 --no-metadata --disk-only Domain snapshot s1 created ➜ ~ virsh blockcommit pc vda --active --wait --verbose --pivot Block commit: [100 %] Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2017 |