Bug 1405871

Summary: Base Runtime FTBFS - gstreamer-0.10.36-14.fc25
Product: [Fedora] Fedora Reporter: Stephen Gallagher <sgallagh>
Component: gstreamerAssignee: Benjamin Otte <otte>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 25CC: mmathesi, otte, psabata, wtaymans
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: gstreamer-0.10.36-15.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-22 16:49:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1400162    
Attachments:
Description Flags
Patch to fix FTBFS sgallagh: review? (otte)

Description Stephen Gallagher 2016-12-19 01:02:49 UTC
Created attachment 1233279 [details]
Patch to fix FTBFS

Description of problem:
When attempting to rebuild portions of the frozen package set of Fedora 25, we discovered that gnupg2 fails to build due to a broken test (tofu.test)

Version-Release number of selected component (if applicable):
gnupg2-2.1.13-2.fc25

How reproducible:
Every time

Steps to Reproduce:
1. fedpkg clone gstreamer
2. fedpkg switch-branch f25
3. fedpkg mock-build

Actual results:

  DOC   Building HTML
mv: cannot stat 'html/index.sgml': No such file or directory

Expected results:
Successful build of the package.

Additional info:
This is needed as part of the Base Runtime effort.

Please find attached a patch that skips using gtk-doc to generate documentation and uses the default doc-generation available from the package.

If you feel it is acceptable, please pull it in and commit it to dist-git.

If you feel the patch is unacceptable, please respond within two weeks with an explanation of why. If we hear no response before then, a provenpackager will make the change so that we can unblock the Base Runtime effort.

Comment 1 Stephen Gallagher 2016-12-19 01:24:35 UTC
If the patch attached does not suffice, I suggest having a look at this fix for similar failures in the gstreamer-plugins-base package:
http://pkgs.fedoraproject.org/cgit/rpms/gstreamer-plugins-base.git/commit/?id=16e16b484f510e6fbabd20dcae49441f53dd44d0

It's more involved than I'm comfortable attempting to implement.

Comment 2 Wim Taymans 2016-12-19 09:58:30 UTC
We have patched the other GStreamer modules by removing the code to strip the version number from the generated docs.

Comment 3 Stephen Gallagher 2016-12-19 13:02:17 UTC
(In reply to Wim Taymans from comment #2)
> We have patched the other GStreamer modules by removing the code to strip
> the version number from the generated docs.

OK, if you have a better fix for this, please go ahead. I was providing what I hoped was a workable quick-fix.

This is blocking out Base Runtime efforts, so I would be highly appreciative if it could be addressed fairly soon.

Comment 4 Wim Taymans 2016-12-19 13:55:57 UTC
(In reply to Stephen Gallagher from comment #3)
> This is blocking out Base Runtime efforts, so I would be highly appreciative
> if it could be addressed fairly soon.

I'm doing it now.

Comment 5 Wim Taymans 2016-12-19 14:16:05 UTC
(In reply to Wim Taymans from comment #4)
> (In reply to Stephen Gallagher from comment #3)
> > This is blocking out Base Runtime efforts, so I would be highly appreciative
> > if it could be addressed fairly soon.
> 
> I'm doing it now.

I pushed a fix but it seems I can't build:

# fedpkg build
Could not execute build: (-1765328377, 'Server not found in Kerberos database')

Comment 6 Stephen Gallagher 2016-12-19 14:21:51 UTC
tl;dr you need to do `kinit fasusername` first and enter your FAS password.

Longer explanation:
* https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/JK267PSDD53I2KGONDLFA5D4JWYXKZTQ/
* https://fedoraproject.org/wiki/Infrastructure/Kerberos

Comment 7 Wim Taymans 2016-12-19 14:24:39 UTC
(In reply to Stephen Gallagher from comment #6)
> tl;dr you need to do `kinit fasusername` first and enter
> your FAS password.
> 
> Longer explanation:
> *
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/
> thread/JK267PSDD53I2KGONDLFA5D4JWYXKZTQ/
> * https://fedoraproject.org/wiki/Infrastructure/Kerberos

Indeed, that works. Not sure how I could have missed this change..

Comment 8 Wim Taymans 2016-12-19 15:03:38 UTC
(In reply to Wim Taymans from comment #7)
> (In reply to Stephen Gallagher from comment #6)
> > tl;dr you need to do `kinit fasusername` first and enter
> > your FAS password.
> > 
> > Longer explanation:
> > *
> > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/
> > thread/JK267PSDD53I2KGONDLFA5D4JWYXKZTQ/
> > * https://fedoraproject.org/wiki/Infrastructure/Kerberos
> 
> Indeed, that works. Not sure how I could have missed this change..

I have built a new version for rawhide, building for f25 now.

Comment 9 Fedora Update System 2016-12-19 16:09:24 UTC
gstreamer-0.10.36-15.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f18c370d7

Comment 10 Stephen Gallagher 2016-12-19 16:31:14 UTC
Thank you very much for the quick turnaround on this!

Comment 11 Fedora Update System 2016-12-20 09:23:59 UTC
gstreamer-0.10.36-15.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f18c370d7

Comment 12 Fedora Update System 2016-12-22 16:49:22 UTC
gstreamer-0.10.36-15.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.