Bug 1405885

Summary:	Fix potential leaks in INODELK cbk in protocol/client
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1405886 (view as bug list)		Environment:
Last Closed:	2017-03-08 10:23:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1405886

Description Krutika Dhananjay 2016-12-19 04:13:54 UTC

Description of problem:

There is a potential leak in protocol/client's INODELK callback:

<code>
 31
 30         GF_PROTOCOL_DICT_UNSERIALIZE (this, xdata, (rsp.xdata.xdata_val),
 29                                       (rsp.xdata.xdata_len), ret,
 28                                       rsp.op_errno, out);
 27
 26         ret = client_post_inodelk (this, &rsp, &xdata);
 25         if (ret < 0)
 24                 goto out;
 23 out:
</code>

The dict xdata is unserialized twice - once at line 30 and once inside client_post_inodelk function called at line 26. This is a memory leak. We're safe as of today because none of the xlators on the client stack that invoke inodelk fop (like AFR, DHT etc) pass xdata while winding it.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-12-19 04:16:03 UTC

REVIEW: http://review.gluster.org/16186 (protocol/client: Fix potential mem-leaks) posted (#1) for review on release-3.9 by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2016-12-21 06:55:06 UTC

COMMIT: http://review.gluster.org/16186 committed in release-3.9 by Raghavendra G (rgowdapp) 
------
commit 5bc916bab68bbb1fe7eac4ffaca5b1e3951cc5ad
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Dec 16 09:31:41 2016 +0530

    protocol/client: Fix potential mem-leaks
    
            Backport of: http://review.gluster.org/16156
    
    Commit 93eaeb9c93be3232f24e840044d560f9f0e66f71 introduces
    leaks in INODELK callback where a dict is unserialized twice,
    leading to dict leaks.
    
    Change-Id: Ib01e7fd3557b59ebb748114195b234b9397bb137
    BUG: 1405885
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/16186
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2017-03-08 10:23:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/