Bug 1406431
| Summary: | RuntimeError Multiple parents found / in generate_one_content_for_group | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Gellert Kis <gekis> | |
| Component: | Appliance | Assignee: | Gregg Tanzillo <gtanzill> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Sudhir Mallamprabhakara <smallamp> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 5.6.0 | CC: | abellott, akarol, ealcaniz, gekis, gtanzill, jfrey, jhardy, jocarter, mruzicka, obarenbo, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.8.0 | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.8.0.4 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1428124 1428125 (view as bug list) | Environment: |
5.5.0.13
|
|
| Last Closed: | 2020-10-28 19:09:50 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1428124, 1428125 | |||
|
Comment 3
CFME Bot
2017-02-24 07:02:10 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/af9e051cb6d0d5b90b0e5448cc8ca15e5557011d commit af9e051cb6d0d5b90b0e5448cc8ca15e5557011d Author: Jason Frey <jfrey> AuthorDate: Fri Feb 24 01:50:55 2017 -0500 Commit: Jason Frey <jfrey> CommitDate: Fri Feb 24 17:07:22 2017 -0500 Fix "Multiple Parents Found" issue when moving a relationship. Originally, `.parent=` was written in terms of `add_children`. However, `add_children` supports duplicating nodes in the tree. This is reasonable because you may have a tree where multiple entries make sense, and for those things that have multiple entries, you wouldn't call `.parent`, you would probably call `.parents` and it is expected that calling `.parent` would blow up with the "Multiple Parents Found" error. However, the expectation of calling `.parent=` is that it will become the new, sole, parent, and so implementing it via add_children is wrong because it creates an oddity in that you can call `.parent=` and then not be able to call `.parent` afterwards. https://bugzilla.redhat.com/show_bug.cgi?id=1379464 https://bugzilla.redhat.com/show_bug.cgi?id=1391850 https://bugzilla.redhat.com/show_bug.cgi?id=1406431 app/models/account.rb | 4 +- app/models/mixins/relationship_mixin.rb | 21 +++++----- lib/extensions/ar_miq_set.rb | 3 +- spec/models/mixins/relationship_mixin_spec.rb | 56 +++++++++++++++++++++++++++ 4 files changed, 71 insertions(+), 13 deletions(-) Gellert, do you know how to reproduce it? I can't reproduce it on my appliance. Thanks I still don't have enough information to reproduce it. I am checking with the customer, the steps to reproduce again and we could verify that it is solved. |