Bug 1406517

Summary:	Review Request: container-selinux - Summary: SELinux policies for container runtimes
Product:	[Fedora] Fedora	Reporter:	Lokesh Mandvekar <lsm5>
Component:	Package Review	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	lsm5, package-review
Target Milestone:	---	Flags:	jchaloup: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-14 03:51:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lokesh Mandvekar 2016-12-20 19:07:52 UTC

Spec URL: https://lsm5/fedorapeople.org/container-selinux/container-selinux.spec
SRPM URL: https://lsm5/fedorapeople.org/container-selinux/SRPMS/container-selinux-1.12.4-29.gitb97d6ca.fc25.src.rpm

Description: SELinux policies for container runtimes

Fedora Account System Username: lsm5

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17003677

Comment 1 Lokesh Mandvekar 2017-01-02 16:51:49 UTC

Spec URL: https://lsm5.fedorapeople.org/container-selinux/container-selinux.spec
SRPM URL: https://lsm5.fedorapeople.org/container-selinux/SRPMS/container-selinux-1.12.4-29.gitb97d6ca.fc25.src.rpm

Comment 2 Lokesh Mandvekar 2017-01-02 16:58:20 UTC

Note: this just takes out the container-selinux parts from docker.spec and makes a standalone package out of it.

We don't have a container-selinux version yet, so I'm just including docker's version number here as that's what was used for the container-selinux subpackage. The version of container-selinux soon to be released will probably be '2.0'.

Comment 3 Jan Chaloupka 2017-01-04 15:10:23 UTC

Based on [1] you are missing "Obsoletes: container-selinux < 2:1.12.5.13". Or whatever version of the docker is the latest in the time of building first container-selinux rpm from the new package.

[1] https://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages

Comment 4 Jan Chaloupka 2017-01-04 15:15:51 UTC

I don't think you need to make the constraint relative:

Obsoletes: docker-selinux <= %{epoch}:%{version}-28

It should be enough to fix it with some comment what is the docker-selinux obsoleted by the particular NEVR. E.g.

Obsoletes: docker-selinux <= 2:1.12.4-28

Comment 5 Jan Chaloupka 2017-01-04 15:17:26 UTC

Otherwise LGTM. Please, resolve the two issues. Once done, I will approve.

Comment 6 Lokesh Mandvekar 2017-01-05 18:25:06 UTC

Done

Spec URL: https://lsm5.fedorapeople.org/container-selinux/container-selinux.spec
SRPM URL: https://lsm5.fedorapeople.org/container-selinux/SRPMS/container-selinux-2.0-1.fc25.src.rpm

Comment 7 Gwyn Ciesla 2017-01-06 15:02:48 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/container-selinux

Comment 8 Fedora Update System 2017-01-06 20:50:19 UTC

container-selinux-2.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-67238cda2f

Comment 9 Fedora Update System 2017-01-06 21:52:45 UTC

container-selinux-2.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-92edc8ea7f

Comment 10 Fedora Update System 2017-01-08 02:21:45 UTC

container-selinux-2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-92edc8ea7f

Comment 11 Fedora Update System 2017-01-14 03:51:10 UTC

container-selinux-2.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.