Bug 1406660

Summary:	"Insert text file" sensitive to HTML-significant characters
Product:	[Fedora] Fedora	Reporter:	Benjamin Herrenschmidt <benh>
Component:	evolution	Assignee:	Milan Crha <mcrha>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	25	CC:	lucilanga, mbarnes, mcrha, tpopela
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	evolution-3.22.4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-21 11:24:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Benjamin Herrenschmidt 2016-12-21 07:32:54 UTC

Description of problem:

When inserting a text file in composer the email addresses in the file a stripped.

Version-Release number of selected component (if applicable):

evolution-3.22.2-1.fc25.

How reproducible:

100%

Steps to Reproduce:
1. Open a new email composer in "Plain Text" mode
2. Set style to "Preformatted"
3. Chose Insert -> Text File
4. Insert a file containing for example:

--- content of file ---
Signed-off-by: Foo <foo>
--- end content of file ---

Actual results:

Signed-off-by: Foo

Expected results:

Signed-off-by: Foo <foo>

Additional info:

This happens in plain text, HTML, normal style, preformatted style etc...

Comment 1 Milan Crha 2016-12-21 11:24:48 UTC

Thanks for a bug report. The problem was that the HTML-significant letters were interpreted as HTML code, thus the "<foo>" was used as an element and not as a regular text. I fixed it with the below changes for the next release.

Created commit 1c13be8 in evo master (3.23.4+) [1]
Created commit 5f082ce in evo gnome-3-22 (3.22.4+) [2]

[1] https://git.gnome.org/browse/evolution/commit/?id=1c13be8
[2] https://git.gnome.org/browse/evolution/commit/?id=5f082ce

Comment 2 Benjamin Herrenschmidt 2016-12-21 19:33:18 UTC

Wow that was fast ! Thanks a lot ! I'll test as soon as it hits the repos.

Comment 3 Benjamin Herrenschmidt 2017-01-24 22:37:53 UTC

I verified the fix on fc25 with the latest update. Thanks !