Bug 1406787
| Summary: | unbundle bear from plee-the-bear | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | MartinKG <mgansser> |
| Component: | plee-the-bear | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | alexjnewt, bugs.michael, hdegoede, tcallawa |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | plee-the-bear-0.7.0-13.fc24 plee-the-bear-0.7.0-13.fc25 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-27 19:18:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1398949 | ||
| Bug Blocks: | |||
|
Description
MartinKG
2016-12-21 13:44:48 UTC
new rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/plee-the-bear.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/plee-the-bear-0.7.0-11.fc25.src.rpm %changelog * Thu Dec 22 2016 Martin Gansser <martinkg> - 0.7.0-11 - add BR bear-devel - set -DBEAR_ENGINE_LIBRARY_DIRECTORY=%%{_libdir}/bear - set -DBEAR_ENGINE_INSTALL_LIBRARY_DIR=%%{_lib}/bear - set -DBEAR_ROOT_DIRECTORY=%%{_includedir}/bear - delete add_subdirectory( bear ) in CMakeLists.txt - correct CMAKE_MODULE_PATH in CMakeLists.txt - correct BEAR_ROOT_DIRECTORY in CMakeLists.txt - correct PTB_LIBRARY_PATH in plee-the-bear/launcher/src/CMakeLists.txt - porting issue https://gcc.gnu.org/gcc-6/porting_to.html in plee-the-bear/lib/src/ptb/item/mini-game/code/sequencer.cpp new rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/plee-the-bear.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/plee-the-bear-0.7.0-12.fc25.src.rpm %changelog * Fri Dec 23 2016 Martin Gansser <martinkg> - 0.7.0-12 - add ptb-CMakeLists.patch Why does plee-the-bear violate the following policy? https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries https://fedoraproject.org/wiki/Bundled_Software_policy > - set -DBEAR_ENGINE_LIBRARY_DIRECTORY=%%{_libdir}/bear
As pointed out in the review request of "bear", it makes no sense to relocate the libs into a private libdir, if the same path is added to the runtime linker's search path (via a ld.so config script). There is not even a file conflict that would avoid, because plee-the-bear also places its bundled bear libs into a private libdir.
I strongly suggest installing bear's libs into global %libdir and starting from there without having to patch every other program to find the libs in that place at build-time.
Have implemented your suggestions. new rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/plee-the-bear.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/plee-the-bear-0.7.0-13.fc25.src.rpm %changelog * Mon Jan 16 2017 Martin Gansser <martinkg> - 0.7.0-13 - set -DBEAR_ENGINE_LIBRARY_DIRECTORY=%%{_libdir} to global %%libdir - set -DBEAR_ENGINE_INSTALL_LIBRARY_DIR=%%{_lib} to global %%lib - set -DPTB_LIBRARY_PATH=%%{_libdir} to global %%libdir - set -DPTB_INSTALL_CUSTOM_LIBRARY_DIR=%%{_lib} global %%lib - set -DPTB_LIBRARY_OUTPUT_PATH=%%{_libdir} to global %%libdir plee-the-bear-0.7.0-13.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f8436310d2 plee-the-bear-0.7.0-13.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-75dae99a36 plee-the-bear-0.7.0-13.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-75dae99a36 plee-the-bear-0.7.0-13.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f8436310d2 plee-the-bear-0.7.0-13.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. plee-the-bear-0.7.0-13.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |