Bug 1406793

Summary: oscap xccdf eval segfaults when @family is invalid value
Product: Red Hat Enterprise Linux 7 Reporter: Marek Haicman <mhaicman>
Component: openscapAssignee: Jan Černý <jcerny>
Status: CLOSED ERRATA QA Contact: Watson Yuuma Sato <wsato>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: mhaicman, mpreisle, openscap-maint, wsato
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 08:45:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
xccdf file
none
sce file
none
oval file none

Description Marek Haicman 2016-12-21 14:04:04 UTC 
Description of problem:
When evaluating attached xccdf with --results-arf option, but without --results, oscap segfaults.

Version-Release number of selected component (if applicable):
openscap-1.2.12-1.el7.x86_64

How reproducible:
Should be realiable

Steps to Reproduce:
1. fetch oval, xccdf and sce.sh file
2.  oscap xccdf eval --results-arf arf.xml xccdf.xml
3.

Actual results:
segfault

Expected results:
program finishes successfully.

Additional info:
Comment 1 Marek Haicman 2016-12-21 14:04:46 UTC 
Created attachment 1234413 [details]
xccdf file
Comment 2 Marek Haicman 2016-12-21 14:05:29 UTC 
Created attachment 1234414 [details]
sce file
Comment 3 Marek Haicman 2016-12-21 14:05:47 UTC 
Created attachment 1234415 [details]
oval file
Comment 6 Marek Haicman 2016-12-21 15:38:17 UTC 
Actually I have confused myself - it segfaults even with --results. So the issue is NOT about having --results-arf used alone.
Comment 7 Martin Preisler 2016-12-21 18:05:17 UTC 
This is caused by affected/@family="posix" which is not a valid value.

That said, I don't think we should segfault in these cases so I have proposed a fix upstream: https://github.com/OpenSCAP/openscap/pull/616
Comment 10 Watson Yuuma Sato 2017-05-23 11:55:29 UTC 
Verified.

NEW:
[0 root@qeos-33 ~]# rpm -qa openscap
openscap-1.2.14-1.el7.x86_64

[0 root@qeos-33 ~]# oscap xccdf eval --results-arf arf.xml xccdf.xml
Title
Rule    xccdf_moc.elpmaxe.www_rule_1
Result  pass

Title
Rule    xccdf_moc.elpmaxe.www_rule_2
Result  notchecked


OLD:
[root@qeos-40 ~]# rpm -qa openscap
openscap-1.2.10-2.el7.x86_64   

[root@qeos-40 ~]# oscap xccdf eval --results-arf arf.xml xccdf.xml
Title
Rule    xccdf_moc.elpmaxe.www_rule_1
Result  pass

Title
Rule    xccdf_moc.elpmaxe.www_rule_2
Result  notchecked 

Segmentation fault
Comment 12 errata-xmlrpc 2017-08-01 08:45:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2291