Bug 1406812
| Summary: | [rebranding] Change vdagent-win service name to "Spice Agent" | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Christophe Fergeau <cfergeau> |
| Component: | spice-vdagent-win | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> |
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | --- | CC: | astepano, bmcclain, cfergeau, dblechte, gklein, lsurette, rbalakri, srevivo, tpelka, uril |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | vdagent-win-4.1-2 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Metrics | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1432533 | ||
| Bug Blocks: | 1405599 | ||
(In reply to Christophe Fergeau from comment #0) > Just noticed > vdservice/vdservice.cpp:#define VD_SERVICE_DISPLAY_NAME TEXT("RHEV Spice > Agent") > > This should be changed to "RHV Spice Agent". This should be changed to "Spice Agent" A patch fixing this bug: https://lists.freedesktop.org/archives/spice-devel/2016-December/034747.html For bug verification: 1. Run: cmd.exe 2. Run: sc getdisplayname vdservice C:\Users\test>sc getdisplayname vdservice [SC] GetServiceDisplayName SUCCESS Name = RHEV Spice Agent OR Run: "services" cmd and find a service in question. C:\Users\test>sc queryex type= service state= all | find /i "spice" DISPLAY_NAME: RHEV Spice Agent or C:\Users\test>net start | find /i "spice" RHEV Spice Agent or services.msc According to comment #2: https://bugzilla.redhat.com/show_bug.cgi?id=1406812#c2 this bug was fixed in vdagent-win-4.1-2. But, 4.1.1.3-0.1.el7/rhv-4.1.1-5 still has next package: rhev-guest-tools-iso-4.1-4.el7ev.noarch which has vdagent-win-4.1-1 # rpm -qf /usr/share/rhev-guest-tools-iso/RHEV-toolsSetup_4.1_4.iso --changelog * Sun Feb 19 2017 Lev Veyde <lveyde> 4.1-4 - Updates: rhev-agent-msi-4.41-2 - Based on: rhev-agent-binaries-4.41-2 * Thu Dec 22 2016 Lev Veyde <lveyde> 4.1-3 - Updates: rhev-agent-msi-4.41-1 rhev-balloon-msi-4.41-1 rhev-vioscsi-msi-4.41-1 rhev-block-msi-4.41-1 rhev-network-msi-4.41-1 rhev-serial-msi-4.41-1 rhev-spice-agent-msi-4.41-1 rhev-spice-guest-msi-4.41-1 rhev-sso-msi-4.41-1 rhev-rng-msi-4.41-1 qemu-ga-msi-4.41-1 rhev-apt-4.41-1 - Based on: rhev-agent-binaries-4.41-1 virtio-win-1.9.0-3.el7 vdagent-win-4.1-1 qxl-win-0.1-24 qemu-ga-win-7.3.2-1 - Initial build for RHEV 4.1 C:\Users\test>sc queryex type= service state= all | find /i "spice" DISPLAY_NAME: Spice Agent C:\Users\test>net start | find /i "spice" Spice Agent Tested on rhv41 4.1.1.7-0.1.el7 / BUILD VERSION: 4.1.1-8 rpm -qf /usr/share/rhev-guest-tools-iso/RHEV-toolsSetup_4.1_5.iso --changelog * Tue Mar 28 2017 Lev Veyde <lveyde> 4.1-5 - Updates: rhev-spice-agent-msi-4.41-2 qemu-ga-msi-4.41-2 - Based on: vdagent-win-4.1-2 qemu-ga-win-7.4.3-1 |
Just noticed vdservice/vdservice.cpp:#define VD_SERVICE_DISPLAY_NAME TEXT("RHEV Spice Agent") This should be changed to "RHV Spice Agent".