Bug 1406833

Summary: Service view VM buttons all click through to first VM
Product: Red Hat CloudForms Management Engine Reporter: Jeff Warnica <jwarnica>
Component: UI - OPSAssignee: Eric Hayes <ehayes>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: high Docs Contact:
Priority: medium    
Version: 5.7.0CC: hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: service
Fixed In Version: 5.8.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1430089 (view as bug list) Environment:
Last Closed: 2017-06-12 17:45:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1430089    

Description Jeff Warnica 2016-12-21 15:24:30 UTC
Version 5.7.0.13-rc3.20161129142908_1d51fd2

On viewing a service, and clicking through to its component VMs through their icons, they all direct to the same (first?) VM of the service.

Comment 3 Harpreet Kataria 2016-12-21 20:45:47 UTC
Eric,

this issue was introduced in commit a4c3c0907a9c481ebaee35f90715922fdb58fc14 in https://github.com/ManageIQ/manageiq/pull/9256. Changing https://github.com/ManageIQ/manageiq/blob/master/app/helpers/quadicon_helper.rb#L31 @quad_vm_attrs ||= vm_quad_link_attributes(item) to vm_quad_link_attributes(item) seems to fix the issue but not sure if that is the correct fix, I could not find any usages of @quad_vm_attrs in the codebase. Please take a look.

Thanks,
~Harpreet

Comment 5 CFME Bot 2017-02-14 09:02:52 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/0da3d068e721890ebc76cf7978335f62406c4f7a

commit 0da3d068e721890ebc76cf7978335f62406c4f7a
Author:     Eric Hayes <eric>
AuthorDate: Mon Feb 13 11:20:35 2017 -0800
Commit:     Eric Hayes <eric>
CommitDate: Mon Feb 13 11:20:35 2017 -0800

    Do not cache vm_quad_link_attributes
    it leads to incorrect links on screens with multiple VM Quadicons.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1406833

 app/helpers/quadicon_helper.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 7 Shveta 2017-04-19 17:30:45 UTC
Fixed.
Verified in 5.8.0.11-beta2.20170418170914_a53d2a7