Bug 1406892

Summary: Base Runtime FTBFS: rsh-0.17-80.fc25
Product: [Fedora] Fedora Reporter: Stephen Gallagher <sgallagh>
Component: rshAssignee: Michal Ruprich <mruprich>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 25CC: luhliari, mmathesi, mruprich, msekleta, psabata
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rsh-0.17-81.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-04 17:18:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1400162    

Description Stephen Gallagher 2016-12-21 18:43:10 UTC
Description of problem:
When attempting to rebuild portions of the frozen package set of Fedora 25, we discovered that rsh fails to build due to a reliance on an ancient BSD-derived code construct. The reason for this failure is that support for this feature was dropped in glibc 2.24 (see: https://sourceware.org/glibc/wiki/Release/2.24#Packaging_Changes)

Version-Release number of selected component (if applicable):
rsh-0.17-80.fc25

How reproducible:
Every time

Steps to Reproduce:
1. fedpkg clone rsh
2. fedpkg mock-build

Actual results:

rlogin.c: In function 'catch_child':
rlogin.c:424:13: error: storage size of 'status' isn't known
  union wait status;

Expected results:
Successful build of the package.

Additional info:
This is needed as part of the Base Runtime effort.

Please find attached a patch that converts login.c to using the modern approach for dealing with wait3() calls.

If you feel it is acceptable, please pull it in and commit it to dist-git.

If you feel the patch is unacceptable, please respond within two weeks with an explanation of why. If we hear no response before then, a provenpackager will make the change so that we can unblock the Base Runtime effort.