Bug 1408167

Summary:	missing link of system on page with list of registered systems through proxy
Product:	Red Hat Satellite 5	Reporter:	Pavel Studeník <pstudeni>
Component:	Server	Assignee:	Gennadii Altukhov <galtukho>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Studeník <pstudeni>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	580	CC:	galtukho, jhutar, rdrazny, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spacewalk-java-2.5.14-64-sat	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-21 12:12:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1340444

Description Pavel Studeník 2016-12-22 11:03:04 UTC

Description of problem:
I register system through proxy to satellite and I go to page 

/rhn/systems/details/ProxyClients.do?sid=<id>

And list of systems is without link to detail of system.

old page (satellite 5.7) was written in perl /network/systems/details/proxy.pxt?sid=<id> and now looks little different, but it is ok, I have problem only with missing links. It is regression. 

Version-Release number of selected component (if applicable):
spacewalk-java-2.5.14-36.el6sat.noarch

How reproducible:
always

Steps to Reproduce:
1. setup proxy
2. register system to satellite through proxy
3. look at page Proxy Clients (Detail system)

Actual results:
missing link - only plain text

Expected results:
I can click on link to detail of system

Comment 1 Gennadii Altukhov 2017-01-12 10:29:39 UTC

Fixed in upstream. spacewalk.git:
21829fd4896d49428e465b37ab240c9e892f5b0e

Comment 2 Jan Hutař 2017-02-03 09:28:40 UTC

This is most probably completely unneeded, but looking into:

https://github.com/spacewalkproject/spacewalk/commit/21829fd4896d49428e465b37ab240c9e892f5b0e

system is now displayed as "${current.serverName}" instead of "${current.name}". If somebody is QEing this, we should make sure that value is for server's profile name (and not e.g. for hostname) to be consistent with rest of the UI.

Comment 4 Gennadii Altukhov 2017-02-03 16:19:35 UTC

spacewalk.git:
8ce250a8ea2185305011f0b3e8697a1680cd5cc9

Comment 8 Pavel Studeník 2017-03-15 12:05:45 UTC

I received ISE 500 when one system is registered through proxy on page /rhn/systems/details/ProxyClients.do?sid=<id>

2017-03-15 14:02:12,804 [TP-Processor1] ERROR com.redhat.rhn.frontend.servlets.SessionFilter - Error duri
ng transaction. Rolling back
javax.servlet.ServletException: javax.servlet.jsp.JspException: Request attribute 'parentUrl' must be set
.   
...
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:299)
        at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
        at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
        at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
        at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
        at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
        at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
        at java.lang.Thread.run(Thread.java:785)
Caused by:
javax.servlet.jsp.JspException: Request attribute 'parentUrl' must be set.
        at com.redhat.rhn.frontend.taglibs.list.ListSetTag.verifyEnvironment(ListSetTag.java:139)
        at com.redhat.rhn.frontend.taglibs.list.ListSetTag.doStartTag(ListSetTag.java:98)
        at org.apache.jsp.WEB_002dINF.pages.systems.sdc.proxyclients_jsp._jspx_meth_rl_005flistset_005f0(Unknown Source)
        at org.apache.jsp.WEB_002dINF.pages.systems.sdc.proxyclients_jsp._jspx_meth_html_005fhtml_005f0(Unknown Source)
        ... 51 more

Comment 9 Gennadii Altukhov 2017-03-16 10:14:27 UTC

Added link to proxy systems details page from client's connection page. 

spacewalk.git:
3077570f0184105028b38358fb38380fd5c66f6d

Comment 10 Gennadii Altukhov 2017-03-16 10:16:17 UTC

Pavel, I cannot reproduce ISE. If you still see this error, please, file a new bug for this and add a good reproducer.

Comment 13 Pavel Studeník 2017-04-06 12:51:58 UTC

Verified spacewalk-java-2.5.14-66.el6sat.noarch