Bug 1408463

Summary: Review Request: perl-Math-BigInt-FastCalc - Math::BigInt::Calc with some XS for more speed
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Math-BigInt-FastCalc-0.500.500-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-06 11:14:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2016-12-23 14:22:36 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Math-BigInt-FastCalc/perl-Math-BigInt-FastCalc.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Math-BigInt-FastCalc/perl-Math-BigInt-FastCalc-0.500.500-1.fc26.src.rpm
Description:
This Perl module provides support for fast big integer calculations.

Fedora Account System Username: ppisar

This package will dual-live with code from perl.spec. perl.spec already delivers perl-Math-BigInt-FastCalc sub-package.

Comment 1 Jitka Plesnikova 2017-01-05 09:58:55 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Math-BigInt-FastCalc-0.500.500-1.fc26.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Math::BigInt::Calc) >= 1.999801
      1 perl(XSLoader)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Math-BigInt-FastCalc-0.500.500-1.fc26.x86_64.rpm | sort | uniq -c
      1 perl(Math::BigInt::FastCalc) = 0.5005
      1 perl-Math-BigInt-FastCalc = 0.500.500-1.fc26
      1 perl-Math-BigInt-FastCalc(x86-64) = 0.500.500-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Math-BigInt-FastCalc*
perl-Math-BigInt-FastCalc.src: W: spelling-error Summary(en_US) Calc -> Cal, Cali, Talc
perl-Math-BigInt-FastCalc.x86_64: W: spelling-error Summary(en_US) Calc -> Cal, Cali, Talc
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-01-05 13:58:00 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Math-BigInt-FastCalc

Comment 3 Petr Pisar 2017-01-06 09:18:02 UTC
Thank you for the review and the repository.

Comment 4 Petr Pisar 2017-01-06 11:14:07 UTC
Sub-package disabled in perl-5.24.0-383.fc26.