Bug 1408467

Summary:	Review Request: perl-Math-BigRat - Arbitrary big rational numbers
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Math-BigRat-0.2611-1.fc26	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-06 11:14:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2016-12-23 14:42:24 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Math-BigRat/perl-Math-BigRat.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Math-BigRat/perl-Math-BigRat-0.2611-1.fc26.src.rpm
Description:
Math::BigRat complements Math::BigInt and Math::BigFloat by providing
support for arbitrary big rational numbers.

Fedora Account System Username: ppisar

This package will dual-live with code from perl.spec. perl.spec already delivers perl-Math-BigRat sub-package.

Comment 1 Jitka Plesnikova 2017-01-05 11:48:03 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Math-BigRat-0.2611-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Carp)
      1 perl(Math::BigFloat)
      1 perl(Math::BigInt) >= 1.999718
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Math-BigRat-0.2611-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Math::BigRat) = 0.2611
      1 perl-Math-BigRat = 0.2611-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Math-BigRat*
perl-Math-BigRat.noarch: W: spelling-error %description -l en_US BigInt -> Big Int, Biting, Big-int
perl-Math-BigRat.noarch: W: spelling-error %description -l en_US BigFloat -> Big Float, Big-float, Bigfoot
perl-Math-BigRat.src: W: spelling-error %description -l en_US BigInt -> Big Int, Biting, Big-int
perl-Math-BigRat.src: W: spelling-error %description -l en_US BigFloat -> Big Float, Big-float, Bigfoot
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-01-05 14:04:02 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Math-BigRat

Comment 3 Petr Pisar 2017-01-06 09:29:11 UTC

Thank you for the review and the repository.

Comment 4 Petr Pisar 2017-01-06 11:14:08 UTC

Sub-package disabled in perl-5.24.0-383.fc26.