Bug 1408942

Summary: Host deploy should install cockpit-ovirt.
Product: [oVirt] ovirt-host-deploy Reporter: Yaniv Lavi <ylavi>
Component: Plugins.GeneralAssignee: Sandro Bonazzola <sbonazzo>
Status: CLOSED CURRENTRELEASE QA Contact: Petr Matyáš <pmatyas>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.6.0CC: bugs, jbelka, lsvaty, mburman, mperina, oourfali, sbonazzo, ylavi
Target Milestone: ovirt-4.2.0Flags: ylavi: ovirt-4.2+
Target Release: 1.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
oVirt Host Deploy now install and maintain updated cockpit-ovirt package on hypervisor hosts.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 10:41:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1460609, 1463124, 1478904    
Bug Blocks:    

Description Yaniv Lavi 2016-12-28 10:10:58 UTC
Description of problem:
We now support cockpit-ovirt on any platform. Please install it to hosts on adding it to engine to make it available for management of the single host.

Comment 1 Yaniv Lavi 2017-01-02 14:40:26 UTC
There is no 1.6.0 version. Can you please add it and set the version on this bug?

Comment 2 Oved Ourfali 2017-02-24 13:05:54 UTC
What about host upgrade and upgrade checks? Will that be part of this fix, or a seperate bug?

Comment 3 Sandro Bonazzola 2017-02-24 13:07:20 UTC
Please note this is valid for x86_64 only since cockpit is not available on el7 for different arches.

Comment 4 Sandro Bonazzola 2017-02-24 13:09:21 UTC
(In reply to Oved Ourfali from comment #2)
> What about host upgrade and upgrade checks? Will that be part of this fix,
> or a seperate bug?

wait a bit, not sure we'll implement this at all.

Please note that requiring cockpit-ovirt means requiting ovirt-hosted-engine-setup as well.
Is this desired?

Comment 5 Yaniv Lavi 2017-02-27 10:16:42 UTC
(In reply to Sandro Bonazzola from comment #4)
> (In reply to Oved Ourfali from comment #2)
> > What about host upgrade and upgrade checks? Will that be part of this fix,
> > or a seperate bug?
> 
> wait a bit, not sure we'll implement this at all.
> 
> Please note that requiring cockpit-ovirt means requiting
> ovirt-hosted-engine-setup as well.
> Is this desired?

I have no issue with this.

Comment 6 Sandro Bonazzola 2017-02-27 10:17:21 UTC
(In reply to Oved Ourfali from comment #2)
> What about host upgrade and upgrade checks? Will that be part of this fix,
> or a seperate bug?

It will be part of this fix

Comment 7 Petr Matyáš 2017-03-06 09:52:29 UTC
Should the package be required when updating ovirt-host-deploy? Since neither cockpit-ovirt-dashboard nor cockpit-ovirt-uiplugin is required by anything.

Or am I required to install them manually?

Comment 8 Red Hat Bugzilla Rules Engine 2017-03-06 09:52:35 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 9 Sandro Bonazzola 2017-03-06 15:29:16 UTC
(In reply to Petr Matyáš from comment #7)
> Should the package be required when updating ovirt-host-deploy? Since
> neither cockpit-ovirt-dashboard nor cockpit-ovirt-uiplugin is required by
> anything.
> 
> Or am I required to install them manually?

You should use host upgrade from web ui.

Comment 10 Petr Matyáš 2017-03-06 16:51:21 UTC
Well, from webadmin -> upgrade this works, but I still think ovirt-host-deploy package should get cockpit-ovirt-dashboard as a dependency

Comment 11 Sandro Bonazzola 2017-03-07 08:50:24 UTC
(In reply to Petr Matyáš from comment #10)
> Well, from webadmin -> upgrade this works, but I still think
> ovirt-host-deploy package should get cockpit-ovirt-dashboard as a dependency

ovirt-host-deploy is installed on engine side and executed remotely copying over a tarball and executing it using ssh.
Adding a direct dependency there won't help anyway except introducing a cyclic dependency.

Comment 12 Sandro Bonazzola 2017-03-07 11:43:07 UTC
This change broke hosted engine installation and upgrade of older cluster levels.
We really need to review the verification process for this bug.

Comment 13 Red Hat Bugzilla Rules Engine 2017-03-07 11:43:14 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 14 Sandro Bonazzola 2017-03-07 11:43:56 UTC
I'll revert the changes.

Comment 15 Sandro Bonazzola 2017-03-08 10:53:59 UTC
Lev, please work with Martin Perina on this

Comment 16 Jiri Belka 2017-03-08 12:30:49 UTC
(In reply to Sandro Bonazzola from comment #12)
> This change broke hosted engine installation and upgrade of older cluster
> levels.
> We really need to review the verification process for this bug.

I also could not also add 3.6 NGN into 4.1 engine with 3.6  cluster level.

Comment 17 Sandro Bonazzola 2017-09-06 14:45:39 UTC
Moving this to modified, since ovirt-host-deploy now install ovirt-host (https://gerrit.ovirt.org/78306) and ovirt-host requires cockpit-ovirt-dashboard (https://gerrit.ovirt.org/#/c/78092/)

Comment 18 Petr Matyáš 2017-10-10 08:45:37 UTC
Verified on ovirt-host-deploy-1.7.0-0.0.master.20170912090102.git1eeb5a2.el7.centos.noarch

Comment 19 Sandro Bonazzola 2017-12-20 10:41:46 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.