Bug 1409000
| Summary: | Review Request: kwalletcli - CLI for the KDE Wallet | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, projects.rg, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-10 06:48:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Orion Poplawski
2016-12-28 20:43:40 UTC
Thanks for your interesting review request.
> %if 0%{?fedora}
> BuildRequires: kf5-kcoreaddons-devel
> BuildRequires: kf5-ki18n-devel
> BuildRequires: kf5-kwallet-devel
> %else
> BuildRequires: kdelibs-devel
> %endif
kf5-kwallet is available in EPEL7, why do you link against kdelibs-devel? Maybe it's better to have support for both KDE4 and KF5, as the description says. My doubt that we want support for KDE 3 in any case, please remove that from the description as it's confusing.
I can review naming: ok licensing: ok sources: ok b5649a18a8187b0fabca7073fabe52c3 kwalletcli-3.00.tar.gz builds/installs: ok macros: ok scriplets: ok (n/a) looks good, APPROVED While kf5-kwallet is available in EPEL7, it's not used by default. I suppose we could build kf5-kwalletcli as well if there was a great demand, but I don't particularly see the point. I've dropped KDE 3 from the description. Thanks for the review, Rex. Pkgdb request submitted. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kwalletcli kwalletcli-3.00-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f30ec62aa kwalletcli-3.00-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-77c19928f8 kwalletcli-3.00-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-289f57518f kwalletcli-3.00-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-289f57518f kwalletcli-3.00-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f30ec62aa kwalletcli-3.00-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-77c19928f8 kf5-kwallet in el7 is used by lxqt-wallet [BuildRequires: cmake(KF5Wallet)], then indirectly used in zulucrypt. Please consider to support that with kwalletcli. kwalletcli-3.00-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-278f76346c kwalletcli-3.00-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-39c85a080d kwalletcli-3.00-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-29ac1fc3d7 kwalletcli-3.00-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-29ac1fc3d7 kwalletcli-3.00-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-278f76346c kwalletcli-3.00-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-39c85a080d kwalletcli-3.00-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. kwalletcli-3.00-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. kwalletcli-3.00-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |