Bug 1409023

Summary:	[Debian] ldmtool not installed in the appliance
Product:	[Community] Virtualization Tools	Reporter:	Laurent Bigonville <bigon>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	ptoscano, rbalakri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-03 18:23:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Laurent Bigonville 2016-12-29 01:05:11 UTC

Description of problem:
On a debian host, when for example starting "virt-inspector" in debug mode, I see the following messaged:

/init: line 138: ldmtool: command not found

Adding the "ldmtool" package to the packagelist fix the issue.

Version-Release number of selected component (if applicable):
1.34.3

How reproducible:
Always

Steps to Reproduce:
1. export LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1
2. virt-inspector /tmp/my_vm.img
3. Read the output

Actual results:
[...]
/init: line 138: ldmtool: command not found
[...]

Expected results:
[...]
ldmtool create all
[...]

Additional info:

Comment 1 Richard W.M. Jones 2016-12-29 02:03:49 UTC

The error message itself isn't a bug.  ldmtool is quite
optional.

However it may be the case that you need ldmtool and so
it would need to be a dependency of the Debian package.  This
does require a small patch for libguestfs:

diff --git a/appliance/packagelist.in b/appliance/packagelist.in
index bbbe4b2..3e22e68 100644
--- a/appliance/packagelist.in
+++ b/appliance/packagelist.in
@@ -74,6 +74,7 @@ dnl iproute has been renamed to iproute2
   iputils-arping
   iputils-tracepath
   isc-dhcp-client
+  ldmtool
   libaugeas0
   libc-bin
   libcap2

Comment 2 Pino Toscano 2017-01-03 18:23:35 UTC

(In reply to Richard W.M. Jones from comment #1)
> However it may be the case that you need ldmtool and so
> it would need to be a dependency of the Debian package.  This
> does require a small patch for libguestfs:
> 
> diff --git a/appliance/packagelist.in b/appliance/packagelist.in
> index bbbe4b2..3e22e68 100644
> --- a/appliance/packagelist.in
> +++ b/appliance/packagelist.in
> @@ -74,6 +74,7 @@ dnl iproute has been renamed to iproute2
>    iputils-arping
>    iputils-tracepath
>    isc-dhcp-client
> +  ldmtool
>    libaugeas0
>    libc-bin
>    libcap2

Makes sense, patch committed also adding the package for Mageia:
https://github.com/libguestfs/libguestfs/commit/e86b36a31c1be9fdf80893a2bc702c40de05ee76
(it is in libguestfs >= 1.35.20)

The Debian packaging will still need to add ldmtool as Build-Depends, and adding ldmtool to some package relationship (Depends, Recommends, Suggests).