Bug 1409665

Created attachment 1236730 [details]
Screenshot of error in Banshee

Description of problem:
I am unable to add a podcast from the Spanish news radio station "Cadena Ser" into Bashee.  When I try, I get a general parsing error.  Other podcasts from different Web sites work.

Version-Release number of selected component (if applicable):
banshee-2.6.2-15.fc24.i686

(Even though I'm using Fedora 25, dnf installed a package with "fc24" in it name, so I assume its the latest one.)

How reproducible:
Every Time

Steps to Reproduce:
1. Start "banshee"
2. From the main menu, select "Media -> Add Podcast..."
3. In the URL box, enter
"""
http://urotrosfiles.media.streamtheworld.com/otrosfiles/podcasts/671p.xml
"""
4. Click the "Subscribe" button

Actual results:
An error message appears at the bottom that says Parsing Error Updating http://urotrosfiles.media.streamtheworld.com/otrosfiles/podcasts/671p.xml

Banshee prints the following to the command line
"""
[Warn  13:44:24.482] Caught an exception - System.Xml.XmlException: Data at the root level is invalid. Line 1, position 1. (in `System.Xml')
  at System.Xml.XmlTextReaderImpl.Throw (System.Exception e) <0xa3c27858 + 0x0007f> in <filename unknown>:0 
  at System.Xml.XmlTextReaderImpl.Throw (System.String res, System.String arg) <0xa3c27388 + 0x0009b> in <filename unknown>:0 
  at System.Xml.XmlTextReaderImpl.Throw (System.String res) <0xa3c27360 + 0x00023> in <filename unknown>:0 
  at System.Xml.XmlTextReaderImpl.ParseRootLevelWhitespace () <0xb3837b28 + 0x00267> in <filename unknown>:0 
  at System.Xml.XmlTextReaderImpl.ParseDocumentContent () <0xb38d0778 + 0x004fb> in <filename unknown>:0 
  at System.Xml.XmlTextReaderImpl.Read () <0xb38ce968 + 0x00053> in <filename unknown>:0 
  at System.Xml.XmlLoader.Load (System.Xml.XmlDocument doc, System.Xml.XmlReader reader, Boolean preserveWhitespace) <0xb38c1f88 + 0x0019f> in <filename unknown>:0 
  at System.Xml.XmlDocument.Load (System.Xml.XmlReader reader) <0xb38c1e20 + 0x00083> in <filename unknown>:0 
  at System.Xml.XmlDocument.LoadXml (System.String xml) <0xb196e200 + 0x00098> in <filename unknown>:0 
  at Migo.Syndication.RssParser..ctor (System.String url, System.String xml) <0xa3c26d08 + 0x00115> in <filename unknown>:0 
[Warn  13:44:24.484] Caught an exception - System.FormatException: Invalid XML document. (in `Migo')
  at Migo.Syndication.RssParser..ctor (System.String url, System.String xml) <0xa3c26d08 + 0x002b3> in <filename unknown>:0 
  at Migo.Syndication.FeedUpdateTask.OnDownloadDataReceived (System.Object sender, Migo.Net.DownloadStringCompletedEventArgs args) <0xa3c264e0 + 0x0024f> in <filename unknown>:0 
"""

Expected results:
The podcast is added as "Negra y Criminal" and its episodes are shown in the right box.


Suggested Work-around:
1) Download the file into an empty directory

curl http://urotrosfiles.media.streamtheworld.com/otrosfiles/podcasts/671p.xml > myrssfile.xml

2) Convert Windows newlines to UNIX newlines
dos2unix myrssfile.xml

3) Host the file on a local web server
python -m SimpleHTTPServer 8000

4) Add the podcast using this URL
http://localhost:8000/myrssfile.xml


Additional info:
Firefox has no trouble rendering the URL as an RSS feed.

I haven't tried to run a banshee built from the latest source.  Based on bug 
#1379508, I'd expect this is not something I'd be able to do.

According to https://www.w3.org/TR/REC-xml/#sec-line-ends

"""
the XML processor MUST behave as if it normalized all line breaks in external parsed entities (including the document entity) on input, before parsing, by translating both the two-character sequence #xD #xA and any #xD that is not followed by #xA to a single #xA character.
"""

This makes me think that the RSS feed should not be considered malformed because of its newlines.  It also suggests that the problem may be in System.Xml.XmlTextReaderImpl, not banshee itself.