Bug 1410072

Summary:	Fix failure of split-brain-favorite-child-policy.t in CentOS7
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1408757	Environment:
Last Closed:	2017-03-08 10:23:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1408757, 1410073
Bug Blocks:

Description Ravishankar N 2017-01-04 11:58:38 UTC

+++ This bug was initially created as a clone of Bug #1408757 +++

Description of problem:

Detailed in https://bugzilla.redhat.com/show_bug.cgi?id=1408660#c2

--- Additional comment from Worker Ant on 2016-12-27 00:44:42 EST ---

REVIEW: http://review.gluster.org/16288 (tests: Fix split-brain-favorite-child-policy.t failures) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2016-12-27 01:36:36 EST ---

REVIEW: http://review.gluster.org/16288 (tests: Fix split-brain-favorite-child-policy.t failures) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2016-12-27 07:21:57 EST ---

REVIEW: http://review.gluster.org/16288 (tests: Fix split-brain-favorite-child-policy.t failures) posted (#3) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2016-12-29 19:30:46 EST ---

REVIEW: http://review.gluster.org/16288 (tests: Fix split-brain-favorite-child-policy.t failures) posted (#4) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-01-03 01:13:56 EST ---

COMMIT: http://review.gluster.org/16288 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 76fff8cb2a164b596ca67e65c99623f5b68361fd
Author: Ravishankar N <ravishankar>
Date:   Thu Dec 29 12:10:00 2016 +0000

    tests: Fix split-brain-favorite-child-policy.t failures
    
    Problem:
    In CentOS-7, the file was receving an extra removexattr(security.ima)
    FOP which changed its ctime, breaking the assumption that a particular brick
    had the latest ctime based on the writevs done in the .t
    
    Fix:
    1. Compare the ctime of both files in the backend and pick the one with
    the latest ctime for the fav-child policy. Also unmount the volume
    before comparing, to avoid any further FOPS on the file that
    can possibly modify the timestamps.
    
    2. Added floating point handling in stat function. Thanks to Pranith for
    the helping debugging the regex.
    
    Change-Id: I06041a0f39a29d2593b867af8685d65c7cd99150
    BUG: 1408757
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/16288
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Worker Ant 2017-01-04 11:59:13 UTC

REVIEW: http://review.gluster.org/16323 (tests: Fix split-brain-favorite-child-policy.t failures) posted (#1) for review on release-3.9 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-01-05 11:42:08 UTC

COMMIT: http://review.gluster.org/16323 committed in release-3.9 by Pranith Kumar Karampuri (pkarampu) 
------
commit 45c7f2f16a2836a715e79d436fbb0bd5a5799284
Author: Ravishankar N <ravishankar>
Date:   Thu Dec 29 12:10:00 2016 +0000

    tests: Fix split-brain-favorite-child-policy.t failures
    
    Problem:
    In CentOS-7, the file was receving an extra removexattr(security.ima)
    FOP which changed its ctime, breaking the assumption that a particular brick
    had the latest ctime based on the writevs done in the .t
    
    Fix:
    1. Compare the ctime of both files in the backend and pick the one with
    the latest ctime for the fav-child policy. Also unmount the volume
    before comparing, to avoid any further FOPS on the file that
    can possibly modify the timestamps.
    
    2. Added floating point handling in stat function. Thanks to Pranith for
    the helping debugging the regex.
    
    > Reviewed-on: http://review.gluster.org/16288
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    (cherry picked from commit 76fff8cb2a164b596ca67e65c99623f5b68361fd)
    
    
    Change-Id: I06041a0f39a29d2593b867af8685d65c7cd99150
    BUG: 1410072
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/16323
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Kaushal 2017-03-08 10:23:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/