Bug 1410204

Summary: [Patch] Fix build against sip-4.19
Product: [Fedora] Fedora Reporter: Sandro Mani <manisandro>
Component: PyQwtAssignee: Tadej Janež <tadej.j>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: rdieter, tadej.j
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-10 14:31:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch none

Description Sandro Mani 2017-01-04 18:38:58 UTC 
Created attachment 1237268 [details]
Patch

Attached patch fixes build against sip-4.19:

https://koji.fedoraproject.org/koji/taskinfo?taskID=17163962
Comment 1 Tadej Janež 2017-01-10 14:31:13 UTC 
(In reply to Sandro Mani from comment #0)
> 
> Attached patch fixes build against sip-4.19:
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=17163962

Thanks, Sandro!

I've applied the patch (along with some other spec updates) and pushed it to rawhide:
https://src.fedoraproject.org/cgit/rpms/PyQwt.git/commit/?id=974991cfedfa7973fb1349b47e28632741ae1996
https://koji.fedoraproject.org/koji/taskinfo?taskID=17233603
Comment 2 Rex Dieter 2017-01-10 14:36:51 UTC 
That's an odd patch, much of it  includes removal of stanzas like:

#if SIP_VERSION < 0x040800
...

which should not be evaluating to true in this context.  Any idea(s) why that is?  (ie, I'd rather fix the version comparison logic rather than working-around it)
Comment 3 Rex Dieter 2017-01-10 14:38:59 UTC 
that said, we (and PyQwt upstream) probably have little to no interest maintaining compatibility for such old sip versions
Comment 4 Sandro Mani 2017-01-10 14:52:54 UTC 
@Rex: The codebase was half-ported to newer SIP verison, i.e. where the
#if SIP_VERSION < 0x040800
appeared. To make it easier to grep through the codebase to ensure I ported everything, I removed the code for the old SIP versions.