Bug 1411110

Summary: Cold Merge: Improve polling of prepareMerge and finalizeMerge steps
Product: [oVirt] ovirt-engine Reporter: Ala Hino <ahino>
Component: BLL.StorageAssignee: Ala Hino <ahino>
Status: CLOSED CURRENTRELEASE QA Contact: Raz Tamir <ratamir>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.1.0CC: ahino, bugs, eberman, gklein, ratamir, tnisan
Target Milestone: ovirt-4.1.0-betaFlags: rule-engine: ovirt-4.1+
Target Release: 4.1.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-15 14:58:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ala Hino 2017-01-08 12:42:53 UTC
Description of problem:
Polling of prepareMerge and finalizeMerge steps (these are SOM Tasks) can be improved by not doing the pre-pollling.

How reproducible:
100%

Steps to Reproduce:
1. Run cold merge

Comment 1 Yaniv Kaul 2017-01-08 13:46:08 UTC
severity?

Comment 2 Carlos Mestre González 2017-01-24 13:18:26 UTC
Can you provide a way to verify this? Not much information on what is suppose to improve (see the pre-polling were not there?)

Comment 3 Ala Hino 2017-01-24 15:06:25 UTC
This fix actually improves performance of cold merge. Maybe you could compare performance of a build containing the patch with a (previous) build that doesn't contain the patch.

Comment 4 Raz Tamir 2017-01-24 15:27:54 UTC
According to comment #3, Eyal, can you please check whether the performance actually improved?

Comment 5 Raz Tamir 2017-02-07 14:24:12 UTC
Verified on ovirt-engine-4.1.0.4-0.1.el7

Previously live merge took ~ 1 minute for a VM with 4 disks
Now, it takes ~ 40 secs