Bug 1411362

Summary: URLs might not be generated properly due to string conversion issue
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED ERRATA QA Contact: Satyajit Bulage <sbulage>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: hkataria, jhardy, mpovolny, obarenbo, sbulage
Target Milestone: GAKeywords: ZStream
Target Release: 5.7.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.7.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1410856 Environment:
Last Closed: 2017-02-27 19:18:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1410856    
Bug Blocks:    

Comment 2 CFME Bot 2017-01-09 14:55:54 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/eff80872cbfb316ac600f934f4006706e65ae93c

commit eff80872cbfb316ac600f934f4006706e65ae93c
Author:     Joe Rafaniello <jrafanie.github.com>
AuthorDate: Tue Nov 8 16:07:19 2016 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Jan 9 09:50:49 2017 -0500

    Merge pull request #12475 from himdel/nil-to_s-or-new
    
    Convert (foo.to_s || "new") to (foo || "new").to_s
    (cherry picked from commit fa4d6c945687cca32797ecac56b98e501fdac922)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1411362

 app/controllers/application_controller/buttons.rb          | 2 +-
 app/controllers/miq_ae_customization_controller/dialogs.rb | 4 ++--
 app/controllers/ops_controller.rb                          | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

Comment 3 Martin Hradil 2017-01-10 14:04:37 UTC
Steps to verify:

go to Automate > Customization, Buttons accordion
click a button group
toolbar Configure > Add a new Button
scroll down to the Visibility section
in the "Show" selectpicker, select "<By Role>"
check a role checkbox and watch network requests (in the inspector Network tab, or in rails log)


expected: POST /miq_ae_customization/automate_button_field_changed/new

bad: POST /miq_ae_customization/automate_button_field_changed/

Comment 4 Satyajit Bulage 2017-01-30 07:43:32 UTC
After performing steps from Comment 3, got expected results: 
POST /miq_ae_customization/automate_button_field_changed/new

Verified Version: 5.7.1.0.20170124142149_8a5f4d5

Comment 6 errata-xmlrpc 2017-02-27 19:18:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2017-0320.html