Bug 1411467

No, this review was less than three days old.

Taking this review.

Some notes:

> rm $RPM_BUILD_ROOT/%{_libdir}/bitlbee/steam.la

Please use %{buildroot} instead of "$RPM_BUILD_ROOT"

> %{!?_licensedir: %global license %%doc}

This should be "%{!?_licensedir: %global license %doc}"


Additional notes:

This package provides "steam.so()(64bit)" which is unhelpfully generic. Please add a Provides filter rule to filter out auto-generated Provides from libraries installed into "%{_libdir}/bitlbee". More information can be found at https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

In reply to Neal Gompa from comment #3)
> Some notes:
> 
> > rm $RPM_BUILD_ROOT/%{_libdir}/bitlbee/steam.la
> 
> Please use %{buildroot} instead of "$RPM_BUILD_ROOT"

The spec file wasn't up to date with current packaging guidelines anyway, so I replaced the calls to make with %make_build and %make_install.  The file is now consistent.

> > %{!?_licensedir: %global license %%doc}
> 
> This should be "%{!?_licensedir: %global license %doc}"

Removed; it isn't necessary any more.

> Additional notes:
> 
> This package provides "steam.so()(64bit)" which is unhelpfully generic.
> Please add a Provides filter rule to filter out auto-generated Provides from
> libraries installed into "%{_libdir}/bitlbee". More information can be found
> at https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

Fixed.  Good catch!

New links:

https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-2.spec
https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-2.src.rpm

Replaced "Requires: bitlbee" with "Requires: bitlbee%{?_isa}"

https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-3.spec
https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-3.src.rpm

Review notes:

+ Package is named appropriately
+ Macros are used consistently
+ Requires and Provides are sane
+ License and documentation are appropriately marked
! File size and checksum mismatch from fedora-review/rpmlint:
  - bitlbee-steam.src: W: file-size-mismatch bitlbee-steam-1.4.2.tar.gz = 375563, https://github.com/bitlbee/bitlbee-steam/archive/v1.4.2/bitlbee-steam-1.4.2.tar.gz = 43003

I guess that's what I get for copypasting from the packaging guidelines without testing them first.  Upstream's source packages come from GitHub's "Releases" page, not archive links, so it now points to the former.  rpmlint still gets angry, but that's because GitHub refuses its HEAD requests.

% sha256sum SOURCES/bitlbee-steam-1.4.2.tar.gz
716bab07dfba5254c8f07d0cd5e29a1a9e6da3e31cdad63803897f814d403f62  SOURCES/bitlb
% curl -Ls $(spectool --lf SPECS/bitlbee-steam.spec) | sha256sum
716bab07dfba5254c8f07d0cd5e29a1a9e6da3e31cdad63803897f814d403f62  -

https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-4.spec
https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-4.src.rpm

Looks good to me, now.

PACKAGE APPROVED.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/bitlbee-steam

bitlbee-steam-1.4.2-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-bcc2712ec1

bitlbee-steam-1.4.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-bcc2712ec1

bitlbee-steam-1.4.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.