Bug 1411961

Taking this review.

Initial comments:

1) You should use Release: 0.1.git%{shortcommit}%{?dist} (including the leading zero), since this is a pre-release snapshot, not a post-release-snapshot.

2) The zlib license has only been confirmed for another repo, but not for this one. Please make sure that the same license applies for this code too.

3) You might want to use a different target file name four your download, for example: "Source0: https://%{provider_prefix}/archive/%{commit}/%{project}-%{repo}-%{shortcommit}.tar.gz" (so _including_ the "project" prefix; no other changes in the .spec file needed), to prevent confusion / conflicts with other package's sources.

4) You can remove the empty %if-%endif blocks at lines 70 and 89.

5) Please remove / adapt the GOPATH definition on line 144, the Godeps directory isn't present in the sources - is this a leftover from an earler version?

6) Please ask upstream to include a COPYING file in this repository too (and link the upstream issue in the .spec file or in a comment here, to document that you did your "homework".

Pinging submitter.

Spec URL: https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-axis2.spec
SRPM URL: https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-axis2-0-0.2.gitb5183a8.fc25.src.rpm

- Clean up template golang spec file, removing Godeps path and an empty ifdef block.
- Renamed download of Source0 to include the project prefix.
- Change versioning to pre-release snapshot versions.
- Include link to upstream bug requesting a license/copying file.
- Added comment asking upstream to add license file.

> 2) The zlib license has only been confirmed for another repo, but not for this one. Please make sure that the same license applies for this code too.

It does; both this code and golang-github-milochristiansen-lua are components of Rubble (http://dffd.bay12games.com/file.php?id=11368). The License file included in that archive has the following text: https://paste.fedoraproject.org/paste/4IDKJAQ4pxQnr13Wsubzk15M1UNdIGYhyRLivL9gydE= which confirms that both axis2 and lua are both zlib licensed.

Furthermore, the source files all contain zlib license headers.

I have filed another ticket against the axis2 repository asking for a license file to be included in that repository though. (I was hoping that upstream would add one to both after I filed the other ticket against the lua repository): https://github.com/milochristiansen/axis2/issues/1

Package looks good now, except for two non-blocking "issues":

1) You missed an empty %if-endif block at line 86.
2) It would be nice if the %description was wrapped at 72 characters (I don't exactly know why, but it seems to be common practice).

You can just fix the %description line lengths before importing into git.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-milochristiansen-axis2

golang-github-milochristiansen-axis2-0-0.3.git20ad745.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe6485afd2

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8831b42f1

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bab763fd2d

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1621f70b10

golang-github-milochristiansen-axis2-0-0.3.git20ad745.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe6485afd2

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1621f70b10

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bab763fd2d

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8831b42f1

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

golang-github-milochristiansen-axis2-0-0.3.git20ad745.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.