Bug 1412558
| Summary: | Check compliance of last known configuration crash | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Gilad Shefer <gshefer> | ||||
| Component: | Automate | Assignee: | Erez Freiberger <efreiber> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Dmitry Misharov <dmisharo> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.7.0 | CC: | cpelland, efreiber, fsimonce, gshefer, hkataria, jfrey, jhardy, mkanoor, obarenbo, simaishi, tfitzger | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.8.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | control:compliance:ui:error | ||||||
| Fixed In Version: | 5.8.0.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1413621 (view as bug list) | Environment: | |||||
| Last Closed: | 2017-06-12 16:47:37 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | Container Management | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1413621 | ||||||
| Attachments: |
|
||||||
Gilad is there no stack trace in one of the logs? Federico, I have looked into this issue, it seems like "Check Compliance of last known Configuration" button is broken for all provider types, commit 129d85dc28f515c18800b9ab55490825a055c4ef(https://github.com/ManageIQ/manageiq/pull/11002) by Alon Goldboim seems to have introduced the issue. I was able to fix the issue if i changed line https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ems_common.rb#L576 from add_flash(_("No %{record} were selected for %{task}") % {model => ui_lookup(:models => model), :task => "Compliance Check"}, :error) to add_flash(_("No %{record} were selected for %{task}") % {model => ui_lookup(:models => model.to_s), :task => "Compliance Check"}, :error) After this change issue was fixed when pressing button from list view, but it still throws an error when pressing same button from Summary screen with error: [----] F, [2017-01-12T17:38:33.844707 #17235:4e3c3a4] FATAL -- : Error caught: [ArgumentError] wrong number of arguments (given 1, expected 3..4) /home/hkataria/dev/manageiq-ui-classic/app/controllers/ems_common.rb:150:in `view_setup_helper' /home/hkataria/dev/manageiq-ui-classic/app/controllers/ems_common.rb:113:in `show_entities' /home/hkataria/dev/manageiq-ui-classic/app/controllers/ems_common.rb:136:in `show' /home/hkataria/dev/manageiq-ui-classic/app/controllers/ems_common.rb:581:in `check_compliance' /home/hkataria/dev/manageiq-ui-classic/app/controllers/ems_common.rb:481:in `button' Can you please have someone look into this, feel free to ping me if you need help. Thanks, ~Harpreet Erez can you check if this is a duplicate of bug 1402349 that you just fixed? This seems a similar problem to https://bugzilla.redhat.com/show_bug.cgi?id=1402349 but different place. we need a new fix as Harpreet mentioned. PR for master: https://github.com/ManageIQ/manageiq-ui-classic/pull/157 Backport PR: https://github.com/ManageIQ/manageiq/pull/13498 The classic ui PR was merged. we should make a clone for zstream. current fix is still lacking Another master PR to finally fix this: https://github.com/ManageIQ/manageiq-ui-classic/pull/172 Verified in 5.8.0.3.20170301174324_1e2e0c4, "Check Compliance of last known Configuration" works without errors. |
Created attachment 1239836 [details] Error Screenshot Description of problem: Check compliance of last known configuration in provider page crash Version-Release number of selected component (if applicable): 5.7 How reproducible: 100% Steps to Reproduce: 1. Create a compliance policy, policy profile, enable this profile in the provider page 2. Compute -> Containers -> Providers -> provider summary page 3. Policy -> Check compliance of last known configuration Actual results: Unexpected error encountered Error text: undefined method `split' for #<Class:0x0000000c49d8b8> Did you mean? split_id [ems_container/button] Expected results: Check compliance of last known configuration Additional info: