Bug 1412801
Summary: | Review Request: python-networkmanager - Easy communication with NetworkManager | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mairi Dulaney <jdulaney> |
Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review |
Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-02-24 22:49:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mairi Dulaney
2017-01-12 20:19:43 UTC
* Any reason to make this python3 stuff conditional? And there is anyway problem with that 34, you should use %python3_pkgversion, but most probably you just don't want to build python3 subpackage under EPEL. Would be better if you will use: %if 0%{?rhel} && 0%{?rhel} <= 7 %bcond_with python3 %else %bcond_without python3 %endif * Move BuildRequires under subpackages (it's more readable) * You can reuse %{summary} from subpackages * Any reason not to take archive from github? * Missing %python_provide macro * GitHub url should be https://, not http:// * %setup -q -n python-networkmanager-%{version}, it's equivalent to %setup -q -n %{name}-%{version} were -n %{name}-%{version} can be omitted. Though I would just replace it with %autosetup * Actually pythonX-setuptools is not needed at all since package doesn't use setuptools for building * I didn't check, but I guess missing Requires: pythonX-dbus * I would recommend to package examples as %doc (kinda useful stuff) Spec URL: https://jdulaney.fedorapeople.org/python-networkmanager.spec SRPM URL: https://jdulaney.fedorapeople.org/python-networkmanager-1.2.1-2.fc25.src.rpm Went through and took care of things; I prefer to use pypi as that feels like a more official release than github; I shall ask the maintainers to see which they prefer. * %doc %{_mandir}/man1/python-networkmanager.1.gz -> %{_mandir}/man1/python-networkmanager.1* * cp docs/_build/man/python-networkmanager.1 %{buildroot}%{_mandir}/man1/ -> this doesn't preserve timestamps actually * %files -n python-networkmanager-doc -> I don't think it's worth to create subpackage for this (examples are not that big, but metadata which is created is bigger ;)) * Since you share man between to packages, you should add Conflicts: pythonX-networkmanager < %{version}-%{release} and Conflicts: pythonX-networkmanager > %{version}-%{release} -> otherwise if people will try to update packages separately, it will fail with file errors * Since you already share files, I would recommend to set %global _docdir_fmt %{name}, so all documentation will be shared in one directory Don't see any blockers though. Spec URL: https://jdulaney.fedorapeople.org/python-networkmanager.spec SRPM URL: https://jdulaney.fedorapeople.org/python-networkmanager-1.2.1-3.fc25.src.rpm I put the manpage into the docs subpackage. I figured having the examples in a subpackage would be better for security, the whole "don't install things that are not necessary" thing. (In reply to John Dulaney from comment #4) > Spec URL: https://jdulaney.fedorapeople.org/python-networkmanager.spec > SRPM URL: > https://jdulaney.fedorapeople.org/python-networkmanager-1.2.1-3.fc25.src.rpm > > I put the manpage into the docs subpackage. I figured having the examples > in a subpackage would be better for security, the whole "don't install > things that are not necessary" thing. There's nothing secure (I mean non-secure) in having examples in main subpackages. You want to split docs only if they are big (>10M) Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-networkmanager python-networkmanager-1.2.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e047129893 python-networkmanager-1.2.1-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9c4df59192 python-networkmanager-1.2.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9c4df59192 python-networkmanager-1.2.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e047129893 python-networkmanager-1.2.1-7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-79ea18d53b python-networkmanager-1.2.1-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9e514f6254 python-networkmanager-1.2.1-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9e514f6254 python-networkmanager-1.2.1-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-79ea18d53b python-networkmanager-1.2.1-7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-networkmanager-1.2.1-7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |