Bug 1412918

Summary:	fuse: Resource leak in fuse-helper under GF_SOLARIS_HOST_OS
Product:	[Community] GlusterFS	Reporter:	Saurabh Badhwar <sbsaurabhbadhwar9>
Component:	fuse	Assignee:	Saurabh Badhwar <sbsaurabhbadhwar9>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, sbsaurabhbadhwar9
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-18 05:31:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Saurabh Badhwar 2017-01-13 06:30:35 UTC

Description of problem:
fuse: The file pointer should be released before returning under the GF_SOLARIS_HOST_OS in fuse-helpers.c which is not being done currently leading to a possible resource leak.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-01-13 07:32:25 UTC

REVIEW: http://review.gluster.org/16395 (fuse: Fix a possible resource leak under GF_SOLARIS_HOST_OS in fuse-helpers.c) posted (#1) for review on master by Saurabh Badhwar (sbsaurabhbadhwar9)

Comment 2 Worker Ant 2017-01-17 20:53:40 UTC

COMMIT: http://review.gluster.org/16395 committed in master by Vijay Bellur (vbellur) 
------
commit 7b61434257f68749bfceee481fa505de7f945747
Author: Saurabh Badhwar <sbsaurabhbadhwar9>
Date:   Fri Jan 13 12:59:51 2017 +0530

    fuse: Fix a possible resource leak under GF_SOLARIS_HOST_OS
    in fuse-helpers.c
    
    Change-Id: Ie367a6dec2a0d5848631b19ebbe39ceafa954a60
    BUG: 1412918
    Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9>
    Reviewed-on: http://review.gluster.org/16395
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Saravanakumar Arumugam <sarumuga>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Saurabh Badhwar 2017-01-18 05:31:43 UTC

Thank you for the reviews and merge.
Fix merged into mainline.

Comment 4 Shyamsundar 2017-03-06 17:43:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/