Bug 1413045
| Summary: | podfying cfme image: in customer portal downloaded image Labels is none | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Dafna Ron <dron> |
| Component: | cfme-container | Assignee: | Barak <bazulay> |
| Status: | CLOSED NOTABUG | QA Contact: | Einat Pacifici <epacific> |
| Severity: | medium | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
| Priority: | unspecified | ||
| Version: | 5.7.0 | CC: | bazulay, dron, fbladilo, jhardy, simaishi |
| Target Milestone: | GA | ||
| Target Release: | cfme-future | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | container | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-26 18:54:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | Container Management | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dafna Ron
2017-01-13 13:13:52 UTC
Why do you think this is a Cloudforms/CM related bug? I don't Isn't it related to the IS label limitation (IIRC default = 5) ? If you do it after setting the "maxImagesBulkImportedPerRepository: 100" (or higher) in the /etc/origin/master/master-config.yaml , and restarting the atomic-openshift-master service. Does it still show the same label ? maxImagesBulkImportedPerRepository: "-1" [root@dafna-openshift-master01 ~]# oc import-image my-cloudforms/cfme4 --from=registry.access.redhat.com/cloudforms/cfme4 --confirm --all The import completed successfully. Name: cfme4 Namespace: cloud09 Created: 14 seconds ago Labels: <none> Annotations: openshift.io/image.dockerRepositoryCheck=2017-01-23T09:56:22Z Docker Pull Spec: 172.30.192.79:5000/cloud09/cfme4 Unique Images: 10 Tags: 10 Satoe, Please keep in mind this is the monolithic image. Do we need to label it differently on build time ? Barak, We have been setting OpenShift labels on the monolithic image for a while : https://github.com/ManageIQ/manageiq/blob/master/Dockerfile#L182 Which labels missing are we referring to? Thanks, I'm not sure which label this is referring either... Dafna, what's the expected value? I suggest refereeing this question to the PM :) I just think that getting a "none" value is not something we would like for an image downloaded from redhat. Barak, Dafna, I don't think this is a bug. The labels that Dafna is referring to, are the labels on the IS object itself, not the images which are actually labeled. When you create an IS object without a deployment template via oc-import like in this example, labels for the IS are not populated. When we deploy the IS using a template (such as the one for the podified release), then these labels get injected into all objects created via template, see here : https://github.com/ManageIQ/manageiq-pods/blob/master/templates/miq-template.yaml#L3 An alternative would be to add the labels by hand, once the IS object is created, this can be done by using "oc edit is". Another alternative is to use oc new-app --docker-image= , etc.. to deploy the monolithic build and have OpenShift create all objects and in that case it will apply labels to all objects created. Thanks, please note the documentation comment: https://access.redhat.com/containers/#/repo/57ea8ce49c624c035f96f370/image/openshift "That command results in the latest version of the image being pulled to the local system. By adding the --all flag to that command line, you would import all tags for the image and not just the latest tag." perhaps documentation need to be changed. I don't think the documentation is 'wrong' as that's talking about image tags, not IS labels. Barak, assigning this to you as this has nothing to do with the actual image, and I'm not sure how we want to handle this ticket.. Per the discussion above and comments #9 #10 & #11, Moving this to CLOSED NOTABUG |