Bug 1413272

As Bug 1264387 Comment #11 mentioned, we have changed to use lockd.conf instead of sysconfig to set module lockd parameters since nfs-utils-1.3.0-0.28.el7

Thank you! Yongcheng.

So as this is an expected behavior shall we close this ticket as not a bug ?

Sorry, I got little confused here, it is expected to read values from module lockd parameter or frp, lockd.conf file here ?

(In reply to Madhur Gupta from comment #3)
> Thank you! Yongcheng.
> 
> So as this is an expected behavior shall we close this ticket as not a bug ?

IMHO, just closing this one as duplicate to bug 1264387 is enough.


(In reply to Madhur Gupta from comment #4)
> Sorry, I got little confused here, it is expected to read values from module
> lockd parameter or frp, lockd.conf file here ?

I only use the config file "lockd.conf" ("/etc/sysconfig/nfs" previously) to specify the lockd parameters. Sorry that I don't know if there is any other method.

------------------------------------------------------------------
[root ~]# grep '.*' -r /sys/module/lockd/parameters/
/sys/module/lockd/parameters/nlm_grace_period:0
/sys/module/lockd/parameters/nlm_tcpport:0
/sys/module/lockd/parameters/nlm_max_connections:1024
/sys/module/lockd/parameters/nlm_timeout:10
/sys/module/lockd/parameters/nsm_use_hostnames:N
/sys/module/lockd/parameters/nlm_udpport:0
[root ~]# cat /etc/modprobe.d/lockd.conf 
#
# Set the NFS lock manager grace period. n is measured in seconds. 
#options lockd nlm_grace_period=90
#
# Set the TCP port that the NFS lock manager should use. 
# port must be a valid TCP port value (1-65535).
#options lockd nlm_tcpport <<<<<<<<<<<<<<<<<<<<<<<<<<
#
# Set the UDP port that the NFS lock manager should use.
# port must be a valid UDP port value (1-65535).
#options lockd nlm_udpport <<<<<<<<<<<<<<<<<<<<<<<<<<
#
# Set the maximum number of outstanding connections 
#options lockd nlm_max_connections=1024
#
# Set the default time value for the NFS lock manager
# in seconds. Default is 10 secs (min 3 max 20)
#options lockd nlm_timeout=10
#
# Choose whether to record the caller_name or IP address
# this peer in the local rpc.statd's database.
#options lockd nsm_use_hostnames=0
[root ~]# rpm -qf /etc/modprobe.d/lockd.conf
nfs-utils-1.3.0-0.33.el7.x86_64

The "lockd" options in /etc/sysconfig/nfs have already been added back in nfs-utils-1.3.0-0.57.el7

Now we have 2 ways to set lockd module's option:
 - via /etc/sysconfig/nfs
 - via /etc/modprobe.d/lockd.conf

From the results of some simple tests, looks like:
- Which configuration taking effect depends on how to load the "lockd" module. I.e.
 * "modprobe lockd" reads config from "/etc/modprobe.d/lockd.conf"
 * "systemctl restart nfs-config" reads config "/etc/sysconfig/nfs"
- After loaded, "LOCKD_TCPPORT" and "LOCKD_UDPPORT" can be modified by restarting nfs-config and reading "/etc/sysconfig/nfs"
- After loaded, other value of "LOCKDARG" cannot be modified unless re-loading it.

This re-expose the issue I reported in Bug 1264387, i.e., "LOCKDARG" of "/etc/sysconfig/nfs" doesn't take effect after restarting nfs-config.service.
However, looks to me now it's probably not a problem.


Please have a look at the testing logs:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[root~]# rpm -q nfs-utils
nfs-utils-1.3.0-0.57.el7.x86_64
[root~]# 
[root~]# cat /etc/modprobe.d/lockd.conf
options lockd nlm_grace_period=90
options lockd nlm_tcpport=33333
options lockd nlm_udpport=33334
[root~]# 
[root~]# cat /etc/sysconfig/nfs
LOCKDARG="nlm_grace_period=120"
LOCKD_TCPPORT=55556
LOCKD_UDPPORT=55557
[root~]# 

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# load "lockd" by nfs-config.service, it's configured by
# /etc/sysconfig/nfs and all values cannot be changed by
# /etc/modprobe.d/lockd.conf
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[root~]# rmmod lockd
[root~]# systemctl restart nfs-config
[root~]# sysctl fs.nfs | grep -E "grace|port"
fs.nfs.nlm_grace_period = 120
fs.nfs.nlm_tcpport = 55556
fs.nfs.nlm_udpport = 55557
[root~]# modprobe lockd
[root~]# sysctl fs.nfs | grep -E "grace|port"
fs.nfs.nlm_grace_period = 120
fs.nfs.nlm_tcpport = 55556
fs.nfs.nlm_udpport = 55557
[root~]# 

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# load "lockd" by command "modprobe", it's configured by
# /etc/modprobe.d/lockd.conf at first and nlm_{tcp,udp}port
# can be updated by /etc/sysconfig/nfs when restarting nfs-config
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[root~]# rmmod lockd
[root~]# modprobe lockd
[root~]# sysctl fs.nfs | grep -E "grace|port"
fs.nfs.nlm_grace_period = 90
fs.nfs.nlm_tcpport = 33333
fs.nfs.nlm_udpport = 33334
[root~]# systemctl restart nfs-config
[root~]# sysctl fs.nfs | grep -E "grace|port"
fs.nfs.nlm_grace_period = 90
fs.nfs.nlm_tcpport = 55556     <<<<<<<<<<<<<<<<<<<<
fs.nfs.nlm_udpport = 55557     <<<<<<<<<<<<<<<<<<<<
[root~]#

Moving to VERIFIED according to comment #18.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3311