Bug 1413371

Summary: Node lifecycle: ability to set node manageable from provisioning state enroll
Product: Red Hat CloudForms Management Engine Reporter: Ronnie Rasouli <rrasouli>
Component: ProvidersAssignee: Richard Su <rwsu>
Status: CLOSED CURRENTRELEASE QA Contact: Ola Pavlenko <opavlenk>
Severity: high Docs Contact:
Priority: high    
Version: 5.7.0CC: jfrey, jhardy, obarenbo, rrasouli, simaishi, tzumainn
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: openstack:provision:infra
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1422654 (view as bug list) Environment:
Last Closed: 2017-06-12 16:32:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1422654    
Description Flags
evm log none

Description Ronnie Rasouli 2017-01-15 13:19:27 UTC
Created attachment 1240937 [details]
evm log

Description of problem:

Currently we support node set to available only if the node is in manageable state, however in case the node is in enroll (if we register node from a file)

The set node to manageable is impossible only if manually setting the newly registered node to manageable 

$ ironic node-list
| 3f7c1253-5cab-4ca3-91de-b694d00aa95e | my_node      | None                                 | None        | enroll             | False       |

Then select the node and select 'Set node as managable' fails 

ironic node-set-provision-state 3f7c1253-5cab-4ca3-91de-b694d00aa95e manage

Then able to set the node as available 

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. register new node in node management
2. select the new node 'Set Nodes to Manageable'

Actual results:

action failed:
 "Manageable": not available for cdf0e401-1436-4dcb-ba5c-3515cb409751. cdf0e401-1436-4dcb-ba5c-3515cb409751's provision state must be in "available", "adoptfail", "cleanfail", or "inspectfail" 

Expected results:

Additional info:

Comment 2 Tzu-Mainn Chen 2017-01-31 15:46:49 UTC
Richard, is this expected behavior, or are there new state changes to consider?

Comment 3 Richard Su 2017-02-07 06:51:04 UTC
Ronnie, when I registered nodes using a file, they automatically go to manageable state. Can you give more details as to how you got nodes to the enroll state?

Comment 6 Richard Su 2017-02-09 07:03:30 UTC
Fix posted for review


Comment 8 Ronnie Rasouli 2017-03-21 13:57:06 UTC
verified on, nodes turn to manageable after import, register nodes