Bug 1413527

This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Created attachment 1266050 [details]
Latest Python3 upstream version

May I ask for a review of the updated spec file?

Hi Ankur,

may I kindly ask for your review of the attached spec file update?

Thank you.

Jan

Hello Jan,

I have looked through the patch. It looks good, but I have a few small comments:

* when building in mock, the build fails with 

> /var/tmp/rpm-tmp.tmnBws: line 31: nosetests: command not found

This can be fixed if you use `nosetests-%{python3_version}` in check section. However there are no tests to be run, so we should either get sources from GitHub or skip test for now and ask upstream to add tests to PyPI tarball.

* as it is not a Python module but a CLI tool, I think we can just switch it to Python 3 without changing the name of the package, or at least provide the old `trash-cli` name.

* I believe the build time dependency on dos2unix is no longer needed, the usage was removed long ago [0].

[0] https://src.fedoraproject.org/cgit/rpms/trash-cli.git/commit/trash-cli.spec?id=c3b966335acd556c94d96eca46a464d506cb45f4

Sorry - been busy. I'll only be able to get to this early next week. Monday hopefully. It's on my list of things to do. 

Again, sorry for the delay.

Cheers!

(In reply to Iryna Shcherbina from comment #4)
Hiya,

Just looked at the patch. Iryna's pointed out the issues already, though:


> 
> I have looked through the patch. It looks good, but I have a few small
> comments:
> 
> * when building in mock, the build fails with 
> 
> > /var/tmp/rpm-tmp.tmnBws: line 31: nosetests: command not found
> 
> This can be fixed if you use `nosetests-%{python3_version}` in check
> section. However there are no tests to be run, so we should either get
> sources from GitHub or skip test for now and ask upstream to add tests to
> PyPI tarball.

+1 to get rid of it. I'll file a ticket upstream asking for the tests to be included in the tar. I expect it'll be done with the new release, but I see no reason to delay the update here on that account.

> 
> * as it is not a Python module but a CLI tool, I think we can just switch it
> to Python 3 without changing the name of the package, or at least provide
> the old `trash-cli` name.

I think providing trash-cli should be sufficient.

> 
> * I believe the build time dependency on dos2unix is no longer needed, the
> usage was removed long ago [0].
> 
> [0]
> https://src.fedoraproject.org/cgit/rpms/trash-cli.git/commit/trash-cli.
> spec?id=c3b966335acd556c94d96eca46a464d506cb45f4

+1


Jan, if you'd like to co-maintain the package and apply this update yourself, please apply for permissions on pkgdb - otherwise I can apply the update on your behalf if you'd like.

Cheers!

Hi,

thanks to Iryna and Ankur for the review.

Ankur, may I ask you to update the spec?

Created attachment 1276619 [details]
Updated Python3 spec file

I have updated the spec file according to the review recommendation:
- just `trash-cli` name is kept
- dos2unix is omitted
- testing is omitted (could be added again when the test is available at PyPI)

trash-cli-0.17.1.14-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7af0df2d2d

Thanks Jan and Iryna - built and update pushed for F26.

trash-cli-0.17.1.14-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7af0df2d2d

trash-cli-0.17.1.14-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.