Bug 1414521

Spec URL: https://download.nohats.ca/unbound16/unbound16.spec
SRPM URL: https://download.nohats.ca/unbound16/unbound16-1.6.0-1.el7.centos.src.rpm
Description:  Validating, recursive, and caching DNS(SEC) resolver
Fedora Account System Username: pwouters

Package is APPROVED.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[-]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: unbound16-1.6.0-1.fc25.x86_64.rpm
          unbound16-munin-1.6.0-1.fc25.noarch.rpm
          unbound16-devel-1.6.0-1.fc25.x86_64.rpm
          unbound16-libs-1.6.0-1.fc25.x86_64.rpm
          python-unbound16-1.6.0-1.fc25.x86_64.rpm
          unbound16-debuginfo-1.6.0-1.fc25.x86_64.rpm
          unbound16-1.6.0-1.fc25.src.rpm
unbound16.x86_64: W: spelling-error %description -l en_US ep -> e, p, esp
unbound16.x86_64: W: spelling-error %description -l en_US resolvers -> resolver, resolves, revolvers
unbound16.x86_64: W: crypto-policy-non-compliance-openssl /usr/sbin/unbound-control SSL_CTX_set_cipher_list
unbound16.x86_64: W: crypto-policy-non-compliance-openssl /usr/sbin/unbound SSL_CTX_set_cipher_list
unbound16.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/local.d unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/conf.d/example.com.conf unbound
unbound16.x86_64: W: non-standard-uid /var/run/unbound unbound
unbound16.x86_64: W: non-standard-gid /var/run/unbound unbound
unbound16.x86_64: E: dir-or-file-in-var-run /var/run/unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/local.d/block-example.com.conf unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/keys.d/example.com.key unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/conf.d unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/keys.d unbound
unbound16.x86_64: W: no-manual-page-for-binary unbound-streamtcp
unbound16-devel.x86_64: W: only-non-binary-in-usr-lib
unbound16-libs.x86_64: W: non-standard-uid /var/lib/unbound/root.key unbound
unbound16-libs.x86_64: W: non-standard-gid /var/lib/unbound/root.key unbound
unbound16-libs.x86_64: W: non-standard-uid /var/lib/unbound unbound
unbound16-libs.x86_64: W: non-standard-gid /var/lib/unbound unbound
unbound16-libs.x86_64: W: non-conffile-in-etc /etc/unbound/icannbundle.pem
unbound16-libs.x86_64: W: pem-certificate /etc/unbound/icannbundle.pem
python-unbound16.x86_64: E: wrong-script-interpreter /usr/share/doc/python-unbound16/dnssec_test.py /usr/bin/env python
python-unbound16.x86_64: W: file-not-utf8 /usr/share/doc/python-unbound16/dict_data.txt
unbound16.src: W: spelling-error %description -l en_US ep -> e, p, esp
unbound16.src: W: spelling-error %description -l en_US resolvers -> resolver, resolves, revolvers
unbound16.src:394: W: macro-in-comment %{with_python3}
unbound16.src:396: W: macro-in-comment %endif
unbound16.src:526: W: macro-in-%changelog %post
7 packages and 0 specfiles checked; 3 errors, 26 warnings.




Rpmlint (debuginfo)
-------------------
Checking: unbound16-debuginfo-1.6.0-1.fc25.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
unbound16-libs.x86_64: W: non-standard-uid /var/lib/unbound unbound
unbound16-libs.x86_64: W: non-standard-gid /var/lib/unbound unbound
unbound16-libs.x86_64: W: non-standard-uid /var/lib/unbound/root.key unbound
unbound16-libs.x86_64: W: non-standard-gid /var/lib/unbound/root.key unbound
unbound16-libs.x86_64: W: non-conffile-in-etc /etc/unbound/icannbundle.pem
unbound16-libs.x86_64: W: pem-certificate /etc/unbound/icannbundle.pem
python-unbound16.x86_64: W: file-not-utf8 /usr/share/doc/python-unbound16/dict_data.txt
python-unbound16.x86_64: E: wrong-script-interpreter /usr/share/doc/python-unbound16/dnssec_test.py /usr/bin/env python
unbound16.x86_64: W: spelling-error %description -l en_US ep -> e, p, esp
unbound16.x86_64: W: spelling-error %description -l en_US resolvers -> resolver, resolves, revolvers
unbound16.x86_64: W: crypto-policy-non-compliance-openssl /usr/sbin/unbound-control SSL_CTX_set_cipher_list
unbound16.x86_64: W: crypto-policy-non-compliance-openssl /usr/sbin/unbound SSL_CTX_set_cipher_list
unbound16.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/unbound
unbound16.x86_64: W: non-standard-uid /var/run/unbound unbound
unbound16.x86_64: W: non-standard-gid /var/run/unbound unbound
unbound16.x86_64: E: dir-or-file-in-var-run /var/run/unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/keys.d unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/keys.d/example.com.key unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/local.d unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/conf.d unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/conf.d/example.com.conf unbound
unbound16.x86_64: W: non-standard-gid /etc/unbound/local.d/block-example.com.conf unbound
unbound16.x86_64: W: no-manual-page-for-binary unbound-streamtcp
unbound16-devel.x86_64: W: only-non-binary-in-usr-lib
6 packages and 0 specfiles checked; 3 errors, 21 warnings.



Requires
--------
unbound16-libs (rpmlib, GLIBC filtered):
    /bin/sh
    /sbin/ldconfig
    config(unbound16-libs)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(OPENSSL_1.0.1_EC)(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libevent-2.0.so.5()(64bit)
    libexpat.so.1()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libunbound.so.2()(64bit)
    rtld(GNU_HASH)
    shadow-utils
    systemd

python-unbound16 (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libevent-2.0.so.5()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libssl.so.10()(64bit)
    libunbound.so.2()(64bit)
    python(abi)
    rtld(GNU_HASH)
    unbound16-libs(x86-64)

unbound16 (rpmlib, GLIBC filtered):
    /bin/sh
    config(unbound16)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(OPENSSL_1.0.1_EC)(64bit)
    libcrypto.so.10(OPENSSL_1.0.2)(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libevent-2.0.so.5()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libunbound.so.2()(64bit)
    rtld(GNU_HASH)
    systemd
    unbound16-libs(x86-64)

unbound16-debuginfo (rpmlib, GLIBC filtered):

unbound16-munin (rpmlib, GLIBC filtered):
    /bin/sh
    bc
    config(unbound16-munin)
    munin-node
    unbound16

unbound16-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libunbound.so.2()(64bit)
    openssl-devel
    pkgconfig
    pkgconfig(libcrypto)
    pkgconfig(libevent)
    pkgconfig(libssl)
    pkgconfig(python)
    unbound16-libs(x86-64)



Provides
--------
unbound16-libs:
    config(unbound16-libs)
    libunbound.so.2()(64bit)
    unbound16-libs
    unbound16-libs(x86-64)

python-unbound16:
    python-unbound16
    python-unbound16(x86-64)
    unbound-python

unbound16:
    config(unbound16)
    unbound16
    unbound16(x86-64)

unbound16-debuginfo:
    unbound16-debuginfo
    unbound16-debuginfo(x86-64)

unbound16-munin:
    config(unbound16-munin)
    unbound16-munin

unbound16-devel:
    pkgconfig(libunbound)
    unbound16-devel
    unbound16-devel(x86-64)



Unversioned so-files
--------------------
python-unbound16: /usr/lib64/python2.7/site-packages/_unbound.so

Source checksums
----------------
http://www.unbound.net/downloads/unbound-1.6.0.tar.gz :
  CHECKSUM(SHA256) this package     : 6b7db874e6debda742fee8869d722e5a17faf1086e93c911b8564532aeeffab7
  CHECKSUM(SHA256) upstream package : 6b7db874e6debda742fee8869d722e5a17faf1086e93c911b8564532aeeffab7


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/bin/fedora-review -b 1414521
Buildroot used: fedora-25-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

this is no longer needed as unbound is getting rebased to 1.6.x for RHEL7