Bug 1414522

Summary: [Behind Proxy][3.3] Cannot use ssh for git repos when http/s proxy is set
Product: OpenShift Container Platform Reporter: Scott Dodson <sdodson>
Component: BuildAssignee: Ben Parees <bparees>
Status: CLOSED ERRATA QA Contact: Wang Haoran <haowang>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.3.1CC: aos-bugs, bparees, dsundqvi, haowang, knakayam, misalunk, pascal.bach, rymurphy, wzheng, xtian
Target Milestone: ---   
Target Release: 3.3.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: atomic-openshift-3.3.1.11-1.git.0.cba037c.el7 Doc Type: Bug Fix
Doc Text:
Cause: Proxy value validation prevented use of default cluster proxy settings with ssh git urls. Consequence: Buildconfigs that used ssh git urls in a cluster with default proxy settings would get a validation error unless the proxy value was explicitly set to empty string in the buildconfig. Fix: Validation will no longer reject buildconfigs that use ssh git urls and have a proxy value set. However the proxy value will not be used when an ssh git url is supplied. Result: Buildconfigs that specify ssh git urls will not get a validation error even if the cluster defines a default git proxy value.
Story Points: ---
Clone Of: 1397475 Environment:
Last Closed: 2017-01-26 20:43:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1397475    
Bug Blocks:    

Comment 2 Wenjing Zheng 2017-01-22 07:44:29 UTC
Have test with below version,still can reproduce this bug:
openshift v3.3.1.9
kubernetes v1.3.0+52492b4
etcd 2.3.0+git

Here are my steps:
1. Create a buildconfig with http/s proxy set:
source:
    git:
      httpProxy: http://XXXXXXX:3128
      httpsProxy: https://XXXXXX:3128
      uri: git://github.com/openshift/ruby-hello-world.git
    type: Git
2. Build config cannot be saved with below error:
spec.source.git.uri: Invalid value: "git://github.com/openshift/ruby-hello-world.git": only http:// and https:// GIT protocols are allowed with HTTP or HTTPS proxy set

If I define gitHTTPProxy/gitHTTPSProxy in master-config.yaml, then start build with git repo, also met above error.

Comment 4 Wenjing Zheng 2017-01-23 03:45:30 UTC
Verified on below version:
openshift v3.3.1.11
kubernetes v1.3.0+52492b4
etcd 2.3.0+git

Comment 6 errata-xmlrpc 2017-01-26 20:43:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0199