Bug 1414748

Summary:	Proxy settings misconfigured
Product:	OpenShift Container Platform	Reporter:	Marko Myllynen <myllynen>
Component:	Installer	Assignee:	Tim Bielawa <tbielawa>
Status:	CLOSED ERRATA	QA Contact:	Gan Huang <ghuang>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.4.0	CC:	aos-bugs, jokerman, mmccomas, myllynen, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: OpenShift Ansible facts were splitting a configuration parameter incorrectly. Consequence: Invalid 'NO_PROXY' strings were generated and inserted into user docker sysconfig files. Fix: Reviewed and fixed the logic that generates the NO_PROXY strings. Result: Valid docker NO_PROXY settings are generated and inserted into the sysconfig/docker file now.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-10 05:17:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marko Myllynen 2017-01-19 11:08:57 UTC

Description of problem:
If using in the inventory file something like

openshift_http_proxy=http://10.10.10.10:8080
openshift_https_proxy=http://10.10.10.10:8080
openshift_no_proxy=10.1.0.0/16,172.30.0.0/16,test.example.com

I see the Docker proxy settings being created correctly. However, if using:

#openshift_http_proxy=http://10.10.10.10:8080
#openshift_https_proxy=http://10.10.10.10:8080
openshift_no_proxy=10.1.0.0/16,172.30.0.0/16,test.example.com

the resulting Docker configuration is broken:

NO_PROXY='1,0,.,1,.,0,.,0,/,1,6,,,1,7,2,.,3,0,.,0,.,0,/,1,6,,,t,e,s,t,.,e,x,a,m,p,l,e,.,c,o,m'

Clearly defining openshift_no_proxy only may not be helpful but the end result should not be like above.

Comment 1 Scott Dodson 2017-01-19 15:33:06 UTC

Which installer version are you using?

Comment 2 Marko Myllynen 2017-01-19 16:22:32 UTC

Seeing this with latest official 3.3/3.4 packages, e.g., 3.4.44-1.git.0.efa61c6.el7. Thanks.

Comment 3 Scott Dodson 2017-01-19 22:14:29 UTC

Proposed fix https://github.com/openshift/openshift-ansible/pull/3131

Comment 4 Tim Bielawa 2017-02-06 16:32:13 UTC

Fixed the merge conflicts and re-running the jenkins tests now.

Comment 5 Tim Bielawa 2017-03-16 17:09:03 UTC

Rerunning the test suites on this now. Maybe they'll pass this time.

Comment 6 Tim Bielawa 2017-06-28 16:05:18 UTC

Testing is running on this again.

Comment 8 Gan Huang 2017-07-06 08:32:33 UTC

Verified with openshift-ansible-3.6.135-1.git.0.5533fe3.el7.noarch.rpm

#cat inventory_hosts
<--snip-->
openshift_no_proxy=".cluster.local,.lab.sjc.redhat.com,10.1.0.0/16,172.30.0.0/16"
<--snip-->

Installation succeed and no_proxy created correctly
# grep 'NO_PROXY' /etc/sysconfig/docker
NO_PROXY='.cluster.local,.lab.sjc.redhat.com,.svc,10.1.0.0/16,172.30.0.0/16,ip-172-18-9-154.ec2.internal'

Comment 10 errata-xmlrpc 2017-08-10 05:17:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716