Bug 1415545

Summary: [Patch] Misc refactoring patches for rh-rhui-tools to follow popular coding guidelines
Product: Red Hat Update Infrastructure for Cloud Providers Reporter: Satoru SATOH <ssato>
Component: ToolsAssignee: RHUI Bug List <rhui-bugs>
Status: CLOSED ERRATA QA Contact: Vratislav Hutsky <vhutsky>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.0.0CC: bkearney, mkubik
Target Milestone: 3.0.7   
Target Release: 3.0.x   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-23 18:05:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch removes use of deprecated lang features like reduce, filter, etc.
none
Patch simplify true/false statements none

Description Satoru SATOH 2017-01-23 02:32:13 UTC 
Description of problem:
Current code of rh-rhui-tools does not look following popular python
coding guidelines that maybe cause decrease of maintainability.

Version-Release number of selected component (if applicable):
RHUI v3 beta.2

Additional info:
I'll upload some PoC patches not tested (unit tests
are must for safer refactoring but it looks not unfortunately.)
Comment 1 Satoru SATOH 2017-01-23 02:34:19 UTC 
Created attachment 1243504 [details]
Patch removes use of deprecated lang features like reduce, filter, etc.

@see https://google.github.io/styleguide/pyguide.html#Deprecated_Language_Features
Comment 4 Satoru SATOH 2017-01-23 02:36:04 UTC 
Created attachment 1243505 [details]
Patch simplify true/false statements

https://google.github.io/styleguide/pyguide.html#True/False_evaluations
Comment 9 errata-xmlrpc 2019-01-23 18:05:13 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0149