Bug 1415634

Some things we must fix:

* The license listed as TODO. Seems like we should put "ASL 2.0" there, based on
  fedora-review's licensecheck.txt output.

* There seems to be some bundled JavaScript in the docs package. I suggest
  symlinking those to the Fedora packaged versions (like jquery), or by
  declaring them as bundled with a Provides: bundled(js-package_name) for each
  of those files. Either of those solutions will be sufficient.


Some suggestions that are optional:

* It seems that the unit tests are being installed. This can be fixed by
  patching the setup.py to exclude the tests. Of course, I suggest sending such
  a patch upstream. Here's an example from the bodhi setup.py:

    https://github.com/fedora-infra/bodhi/blob/2.3.3/setup.py#L152-L153

  Another way to do it would be to just rm them, but I think doing it upstream
  in the setup.py is friendlier.

* You can preserve the timestamps on your cp commands if you use the -p flag.

* You can ln -s your man page for all the Python version variants (so man
  murano-pkg-check-3 still works).

Thanks for the review Randy. I have uploaded an updated version to:

- Spec: https://jpena.fedorapeople.org/murano-pkg-check/python-murano-pkg-check.spec
- SRPM: https://jpena.fedorapeople.org/murano-pkg-check/python-murano-pkg-check-0.3.0-1.fc26.src.rpm

Koji scratch build available at https://koji.fedoraproject.org/koji/taskinfo?taskID=17840954

A couple notes:

- The bundled JS is added by the doc building tools, so I've opted to declare those as Provides: bundled()

- About the unit tests, this is the norm with all OpenStack projects (unit tests always get installed), so I've excluded them from the resulting packages for simplicity.

I recommend adding versions to the Provides bundled() statements, but I don't think that's required to approve.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
     generated", "*No copyright* Apache (v2.0)". 32 files have unknown
     license. Detailed output of licensecheck in
     /home/rbarlow/reviews/1415634-python-murano-pkg-check/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
     randy: bundled js libraries are declared.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: python2-murano-pkg-check (description), python3
     -murano-pkg-check (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -murano-pkg-check , python-murano-pkg-check-doc , python3-murano-pkg-
     check
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-murano-pkg-check-0.3.0-1.fc26.noarch.rpm
          python-murano-pkg-check-doc-0.3.0-1.fc26.noarch.rpm
          python3-murano-pkg-check-0.3.0-1.fc26.noarch.rpm
          python-murano-pkg-check-0.3.0-1.fc26.src.rpm
python2-murano-pkg-check.noarch: W: spelling-error Summary(en_US) validator -> lavatorial
python2-murano-pkg-check.noarch: W: unexpanded-macro %description -l C %{description}
python2-murano-pkg-check.noarch: W: manual-page-warning /usr/share/man/man1/murano-pkg-check.1.gz 45: warning: macro `.' not defined
python-murano-pkg-check-doc.noarch: W: summary-not-capitalized C murano-pkg-check documentation
python-murano-pkg-check-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-murano-pkg-check-doc/html/.buildinfo
python-murano-pkg-check-doc.noarch: W: file-not-utf8 /usr/share/doc/python-murano-pkg-check-doc/html/objects.inv
python3-murano-pkg-check.noarch: W: spelling-error Summary(en_US) validator -> lavatorial
python3-murano-pkg-check.noarch: W: unexpanded-macro %description -l C %{description}
python3-murano-pkg-check.noarch: W: manual-page-warning /usr/share/man/man1/murano-pkg-check-3.1.gz 45: warning: macro `.' not defined
python-murano-pkg-check.src: W: spelling-error Summary(en_US) validator -> lavatorial
python-murano-pkg-check.src: W: spelling-error %description -l en_US validator -> lavatorial
python-murano-pkg-check.src:60: W: unversioned-explicit-provides bundled(js-doctools)
python-murano-pkg-check.src:61: W: unversioned-explicit-provides bundled(js-jquery)
python-murano-pkg-check.src:62: W: unversioned-explicit-provides bundled(js-searchtools)
python-murano-pkg-check.src:63: W: unversioned-explicit-provides bundled(js-underscore)
python-murano-pkg-check.src:64: W: unversioned-explicit-provides bundled(js-websupport)
4 packages and 0 specfiles checked; 0 errors, 16 warnings.




Rpmlint (installed packages)
----------------------------
python-murano-pkg-check-doc.noarch: W: summary-not-capitalized C murano-pkg-check documentation
python-murano-pkg-check-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-murano-pkg-check-doc/html/.buildinfo
python-murano-pkg-check-doc.noarch: W: file-not-utf8 /usr/share/doc/python-murano-pkg-check-doc/html/objects.inv
python3-murano-pkg-check.noarch: W: spelling-error Summary(en_US) validator -> lavatorial
python3-murano-pkg-check.noarch: W: unexpanded-macro %description -l C %{description}
python3-murano-pkg-check.noarch: W: manual-page-warning /usr/share/man/man1/murano-pkg-check-3.1.gz 45: warning: macro `.' not defined
python2-murano-pkg-check.noarch: W: spelling-error Summary(en_US) validator -> lavatorial
python2-murano-pkg-check.noarch: W: unexpanded-macro %description -l C %{description}
python2-murano-pkg-check.noarch: W: manual-page-warning /usr/share/man/man1/murano-pkg-check.1.gz 45: warning: macro `.' not defined
3 packages and 0 specfiles checked; 0 errors, 9 warnings.



Requires
--------
python-murano-pkg-check-doc (rpmlib, GLIBC filtered):

python3-murano-pkg-check (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3-PyYAML
    python3-oslo-i18n
    python3-pbr
    python3-semantic_version
    python3-setuptools
    python3-six
    python3-stevedore
    python3-yaql

python2-murano-pkg-check (rpmlib, GLIBC filtered):
    /usr/bin/python2
    PyYAML
    python(abi)
    python-oslo-i18n
    python-pbr
    python-semantic_version
    python-setuptools
    python-six
    python-stevedore
    python-yaql



Provides
--------
python-murano-pkg-check-doc:
    bundled(js-doctools)
    bundled(js-jquery)
    bundled(js-searchtools)
    bundled(js-underscore)
    bundled(js-websupport)
    python-murano-pkg-check-doc

python3-murano-pkg-check:
    python3-murano-pkg-check
    python3.6dist(murano-pkg-check)
    python3dist(murano-pkg-check)

python2-murano-pkg-check:
    python-murano-pkg-check
    python2-murano-pkg-check
    python2.7dist(murano-pkg-check)
    python2dist(murano-pkg-check)



Source checksums
----------------
https://tarballs.openstack.org/murano-pkg-check/murano-pkg-check-0.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : 56d2c45cdaf3a51e0946e5701dfc76d38262d42c47d077680c2b56210acfd485
  CHECKSUM(SHA256) upstream package : 56d2c45cdaf3a51e0946e5701dfc76d38262d42c47d077680c2b56210acfd485


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1415634
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-murano-pkg-check

> Requires:       PyYAML >= 3.10.0

This fails on EL7 which has PyYAML-3.10-11.el7.x86_64 (base)

Please apply this patch to make it work on EL7:
diff --git a/python-murano-pkg-check.spec b/python-murano-pkg-check.spec
index 07691cd..534a64c 100644
--- a/python-murano-pkg-check.spec
+++ b/python-murano-pkg-check.spec
@@ -8,7 +8,7 @@
 
 Name:           python-%{pypi_name}
 Version:        0.3.0
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Murano package validator tool
 
 License:        ASL 2.0
@@ -45,7 +45,7 @@ Summary:        Murano package validator tool
 %{?python_provide:%python_provide python2-%{pypi_name}}
 
 Requires:       python-pbr >= 1.6
-Requires:       PyYAML >= 3.10.0
+Requires:       PyYAML >= 3.10
 Requires:       python-yaql >= 1.1.0
 Requires:       python-six >= 1.9.0
 Requires:       python-stevedore >= 1.16.0
@@ -90,7 +90,7 @@ BuildRequires:  python3-yaql
 BuildRequires:  python3-stevedore
 
 Requires:       python3-pbr >= 1.6
-Requires:       python3-PyYAML >= 3.10.0
+Requires:       python3-PyYAML >= 3.10
 Requires:       python3-yaql >= 1.1.0
 Requires:       python3-six >= 1.9.0
 Requires:       python3-stevedore >= 1.16.0

Thanks, I've updated the Fedora build with this: https://koji.fedoraproject.org/koji/buildinfo?buildID=859379