Bug 1415662
| Summary: | Review Request: perl-Task-Kensho-Async - Glimpse at an Enlightened Perl (Async Programming) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Task-Kensho-Async-0.39-1.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-24 07:35:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jitka Plesnikova
2017-01-23 11:45:14 UTC
URL and Source0 addresses are usable. Ok.
Source archive (SHA-256: 9a4fc6d333d7216003042d775d182b6f830619163737b6e9dce0060e08eb1b24) is original. Ok.
Summary verified in lib/Task/Kensho/Async.pm. Ok.
Description verified in lib/Task/Kensho/Async.pm. Ok.
License verified in LICENSE, lib/Task/Kensho/Async.pm. Ok.
No XS code, noarch BuildArch is Ok.
Module::Build::Tiny is not needed for building. Ok.
CPAN::Meta and CPAN::Meta::Prereqs are not needed for tests. Ok.
All tests pass. Ok.
$ rpmlint perl-Task-Kensho-Async.spec ../SRPMS/perl-Task-Kensho-Async-0.39-1.fc26.src.rpm ../RPMS/noarch/perl-Task-Kensho-Async-0.39-1.fc26.noarch.rpm
perl-Task-Kensho-Async.src: W: spelling-error %description -l en_US amongst -> among st, among-st, among
perl-Task-Kensho-Async.noarch: W: spelling-error %description -l en_US amongst -> among st, among-st, among
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-Async-0.39-1.fc26.noarch.rpm
drwxr-xr-x 2 root root 0 Jan 23 13:49 /usr/share/doc/perl-Task-Kensho-Async
-rw-r--r-- 1 root root 6779 May 14 2016 /usr/share/doc/perl-Task-Kensho-Async/Changes
-rw-r--r-- 1 root root 1606 May 14 2016 /usr/share/doc/perl-Task-Kensho-Async/README
drwxr-xr-x 2 root root 0 Jan 23 13:49 /usr/share/licenses/perl-Task-Kensho-Async
-rw-r--r-- 1 root root 18352 May 14 2016 /usr/share/licenses/perl-Task-Kensho-Async/LICENSE
-rw-r--r-- 1 root root 2892 Jan 23 13:49 /usr/share/man/man3/Task::Kensho::Async.3pm.gz
drwxr-xr-x 2 root root 0 Jan 23 13:49 /usr/share/perl5/vendor_perl/Task
drwxr-xr-x 2 root root 0 Jan 23 13:49 /usr/share/perl5/vendor_perl/Task/Kensho
-rw-r--r-- 1 root root 4017 May 14 2016 /usr/share/perl5/vendor_perl/Task/Kensho/Async.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-Async-0.39-1.fc26.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.24.1)
1 perl(IO::Async)
1 perl(POE)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Run-time requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-Async-0.39-1.fc26.noarch.rpm | sort -f | uniq -c
1 perl(Task::Kensho::Async) = 0.39
1 perl-Task-Kensho-Async = 0.39-1.fc26
Provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Task-Kensho-Async-0.39-1.fc26.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17391798). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Task-Kensho-Async Thank you for the review and the repository. |