Bug 1416285
Summary: | EXPECT_WITHIN is taking too much time even if the result matches with expected value | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Ashish Pandey <aspandey> |
Component: | tests | Assignee: | Ashish Pandey <aspandey> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.10 | CC: | bugs, pkarampu |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.10.0 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1412549 | Environment: | |
Last Closed: | 2017-03-06 17:44:28 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1412549 | ||
Bug Blocks: |
Description
Ashish Pandey
2017-01-25 07:05:52 UTC
REVIEW: https://review.gluster.org/16467 (tests/include : EXPECT_WITHIN takes full time even if expression matches) posted (#1) for review on release-3.10 by Ashish Pandey (aspandey) COMMIT: https://review.gluster.org/16467 committed in release-3.10 by Shyamsundar Ranganathan (srangana) ------ commit 10076acaddfa611214e42e0402c3578bc69cada9 Author: Ashish Pandey <aspandey> Date: Thu Jan 12 14:48:28 2017 +0530 tests/include : EXPECT_WITHIN takes full time even if expression matches Problem: For all the tests using get_pending_heal_count, EXPECT_WITHIN is taking full time given to it even if the heal count matches with expected value. Solution: RC - In most of the tests, to check heal count, wildcards are being used. In EXPECT_WITHIN, in if condition, when we use it in double quotes (" "), it gives string with wildcards which does not match with the output of get_pending_heal_count. For example, (0 =~ ^0$). So, "while" loop was running for full time and at the end, after coming out of loop, in next if condition it was matching with the expression without quotes. That is why it was passing. Remove double quotes in "if condition" in EXPECT_WITHIN and match as we are matching it in test_expect_footer. >Change-Id: Ia161594774d05b9b888efb2f7ed1950590d8ac1b >BUG: 1412549 >Signed-off-by: Ashish Pandey <aspandey> >Reviewed-on: https://review.gluster.org/16382 >Smoke: Gluster Build System <jenkins.org> >Reviewed-by: Jeff Darcy <jdarcy> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.org> >Reviewed-by: Raghavendra Talur <rtalur> >Signed-off-by: Ashish Pandey <aspandey> Change-Id: Ia161594774d05b9b888efb2f7ed1950590d8ac1b BUG: 1416285 Signed-off-by: Ashish Pandey <aspandey> Reviewed-on: https://review.gluster.org/16467 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report. glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html [2] https://www.gluster.org/pipermail/gluster-users/ |