Bug 1416455
| Summary: | Review Request: python-easywatch - super simple directory monitoring | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <fale> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | athoscribeiro, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-08-08 00:45:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 1416458 | ||
|
Description
Fabio Alessandro Locati
2017-01-25 14:42:31 UTC
Hello Fabio,
The summary for the python3 package is the summary of another package. You could use the summary macro to avoid that.
It would be nice ask upstream to add tags to avoid getting sources from the commits (of course this is not a blocker).
rpmlint has this warning, would you fix it (not a blocker)?
python2-easywatch.noarch: W: summary-not-capitalized C super simple directory monitoring
This is the docstring for easywatch/easywatch.py
"""
Simple static page generator.
Uses jinja2 to compile templates.
Templates should live inside `./templates` and will be compiled in '.'.
"""
It would be nice to patch it and send it upstream.
python3 package fails importing watchdog function (see __init__.py), here is the error message:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.6/site-packages/easywatch/__init__.py", line 1, in <module>
from easywatch import watch
ImportError: cannot import name 'watch'
This happens because __init__.py has a relative import (see https://www.python.org/dev/peps/pep-0404/). I'd say the package is not python3 compatible yet (probably just because of that import)
Finally, there are Requires: missing, as you can see below:
in easywatch/easywatch.py we have:
from watchdog.observers import Observer
from watchdog.events import FileSystemEventHandler
importing the python2 package results in:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'watchdog'
0.0.4 was released. Hi Fabio, still interested on this one? (In reply to Athos Ribeiro from comment #3) > Hi Fabio, still interested on this one? Hmm, I'm not the reporter. Looks like that this review is not going on (-> You can't ask Fabio Alessandro Locati <fale> because that account is disabled.). Sorry for the mistake, Fabian. I will just drop this then This is an automatic action taken by review-stats script. The submitter account doesn't exist anymore, therefore this ticket will be closed. |