Bug 1416691
Summary: | gettext-0.19.8.1-3.fc25 FTBFS when building without git | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Merlin Mathesius <mmathesi> | ||||
Component: | gettext | Assignee: | Pavel Raiskup <praiskup> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 25 | CC: | dueno, i18n-bugs, petersen, praiskup, psabata, sgallagh | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2017-01-26 15:03:29 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1400162 | ||||||
Deadline: | 2017-02-09 | ||||||
Attachments: |
|
Description
Merlin Mathesius
2017-01-26 09:25:32 UTC
Created attachment 1244654 [details]
proposed patch to correct FTBFS issue and git dependency
Speaking about BuildRequires issue ... so does that mean that you can't build Base Runtime package against non-Base Runtime package? Why? I mean, what's wrong on '%autosetup -S git'? I'll rather drop that unconditionally because that's not related to 'bcond_with git' switch .. Also, doing such changes is a bit annoying, there's basically nothing wrong on '-S git' ... and I'm curious whether you document somewhere that it is from now forbidden to use '%autosetup -S git' from now for "certain" set of packages. Sorry if I wasn't clear, but there are two things are going on here. 1. There's nothing wrong with using %autosetup '-S git', but it does mean there needs to be a 'BuildRequires: git'--since git is not otherwise guaranteed to be in the buildroot. That BR is currently within a "%{with git}" conditional. Thus, when attempting to build using the --without=git, the build fails. 2. For Base Runtime, we are making every effort to eliminate unnecessary mandatory dependencies to minimize the size. Base Runtime should include the gettext-devel subpackage, but we do not want to include git, Changing the "Requires: git" to "Recommends: git" will allow that--since git doesn't need to be a strict requirement. Such a change should also do no harm for the standard Fedora releases. (In reply to Merlin Mathesius from comment #4) > Sorry if I wasn't clear, but there are two things are going on here. > > 1. There's nothing wrong with using %autosetup '-S git', but it does mean > there needs to be a 'BuildRequires: git'--since git is not otherwise > guaranteed to be in the buildroot. That BR is currently within a "%{with > git}" conditional. Thus, when attempting to build using the --without=git, > the build fails. That sounds good then. We can have the BuildRequires unconditional. > 2. For Base Runtime, we are making every effort to eliminate unnecessary > mandatory dependencies to minimize the size. Base Runtime should > include the gettext-devel subpackage, but we do not want to include > git, Changing the "Requires: git" to "Recommends: git" will allow > that--since git doesn't need to be a strict requirement. Such a > change should also do no harm for the standard Fedora releases. Based on bug 1161284 (and based on /bin/autopoint source code), we can avoid git dependency. Rawhide: http://pkgs.fedoraproject.org/cgit/rpms/gettext.git/commit/?id=83c226dd020a8f15 Can you confirm it is OK? There was also bug 1405433 (related to Base Runtime?), which was _not_ merged into F25. So I guess it is OK to stay in Rawhide with this bugreport, right? Rawhide is fine. Thank you for the quick fix! |